From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] scripts/mkversion: Simplify script
Date: Thu, 19 Aug 2010 08:26:16 +0530 [thread overview]
Message-ID: <20100819023705.GF3688@kytes> (raw)
In-Reply-To: <20100819002006.GA13637@merkur.ravnborg.org>
Hi,
Sam Ravnborg writes:
> On Thu, Aug 19, 2010 at 02:42:25AM +0530, Ramkumar Ramachandra wrote:
> > Simplify the script and add a line to help editors recognize this as a
> > shell script.
>
> This does not IMO simplify the script.
> The original version is simple to follow for the usual C coder.
> The new version is harder to follow.
>
> Adding the bangshee (#!/bin/sh) is fine.
Okay, we can drop the patch.
I'll pick up some other janiorial tasks to get into the hang of
writing patches.
-- Ram
prev parent reply other threads:[~2010-08-19 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 21:12 [PATCH] scripts/mkversion: Simplify script Ramkumar Ramachandra
2010-08-19 0:20 ` Sam Ravnborg
2010-08-19 2:56 ` Ramkumar Ramachandra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819023705.GF3688@kytes \
--to=artagnon@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox