From: Jean Delvare <khali@linux-fr.org>
To: "Fenghua Yu" <fenghua.yu@intel.com>
Cc: "Rudolf Marek" <r.marek@assembler.cz>,
"Huaxu Wan" <huaxu.wan@intel.com>,
"H Peter Anvin" <hpa@zytor.com>,
"Chen Gong" <gong.chen@linux.intel.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"lm-sensors" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables
Date: Thu, 19 Aug 2010 09:24:23 +0200 [thread overview]
Message-ID: <20100819092423.00f76256@hyperion.delvare> (raw)
In-Reply-To: <1282172027-640-2-git-send-email-fenghua.yu@intel.com>
Hi Fenghua,
On Wed, 18 Aug 2010 15:53:46 -0700, Fenghua Yu wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
>
> Remove compilation warnings of unused variables p and n in coretemp_init().
>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> drivers/hwmon/coretemp.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index c070c97..de81111 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -518,7 +518,6 @@ static struct notifier_block coretemp_cpu_notifier __refdata = {
> static int __init coretemp_init(void)
> {
> int i, err = -ENODEV;
> - struct pdev_entry *p, *n;
>
> /* quick check if we run Intel */
> if (cpu_data(0).x86_vendor != X86_VENDOR_INTEL)
Thanks for the fix, but it is already in my tree:
ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-hwmon/hwmon-coretemp-fix-warning.patch
I'll send it to Linus as part as my next batch of hwmon fixes for
2.6.36.
--
Jean Delvare
next prev parent reply other threads:[~2010-08-19 7:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 22:53 [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Fenghua Yu
2010-08-18 22:53 ` [PATCH] drivers/hwmon/coretemp: Remove warnings of unused variables Fenghua Yu
2010-08-19 7:24 ` Jean Delvare [this message]
2010-08-19 19:04 ` H. Peter Anvin
2010-08-19 21:26 ` Jean Delvare
2010-08-19 21:28 ` H. Peter Anvin
2010-08-19 21:32 ` Jean Delvare
2010-08-19 21:51 ` [lm-sensors] " Guenter Roeck
2010-09-04 12:39 ` Jean Delvare
2010-09-04 14:30 ` Guenter Roeck
2010-09-04 16:17 ` Jean Delvare
2010-08-18 22:53 ` [PATCH] drivers/hwmon/pkgtemp: Fix improper locking in CPU hot remove Fenghua Yu
2010-08-19 17:07 ` [lm-sensors] [PATCH] drivers/hwmon/coretemp: Fix incorrect hot-removed CPU's core sensor issue Guenter Roeck
2010-08-20 8:26 ` Jean Delvare
2010-08-20 21:53 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819092423.00f76256@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=fenghua.yu@intel.com \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=huaxu.wan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=r.marek@assembler.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox