From: Greg KH <gregkh@suse.de>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Raju Rameshwar Uprade <rajsingh@ncra.tifr.res.in>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
maxinbjohn@gmail.com, orest.bond@outpostembedded.com,
vijaykumar@zilogic.com
Subject: Re: Regarding USB-Serial Device driver
Date: Thu, 19 Aug 2010 07:18:12 -0700 [thread overview]
Message-ID: <20100819141812.GA12375@suse.de> (raw)
In-Reply-To: <201008190938.44532.marek.vasut@gmail.com>
On Thu, Aug 19, 2010 at 09:38:44AM +0200, Marek Vasut wrote:
> Dne ??t 19. srpna 2010 08:17:30 Raju Rameshwar Uprade napsal(a):
> > Dear Sir,
> > I am trying to write a Pl2303_mcm.c usb-serial device driver which
> > will be able to talk to several devices using RS-485 interface card.I have
> > modified the standard pl2303.c by which I am able to enable/disable the
> > RTS line.
> > I am sending 10 bytes of data to the device, data is going out but instead
> > of 10 bytes, device driver is sending a large amount of data as seen on
> > Lecroy waverunner oscilloscope. Here I am sending the modified file.
>
> Hi, I have no idea why I'm CCed in this, but anyway.
>
> 1) could you please update the driver to a more recent kernel (we are 10 kernel
> versions further now)
> 2) could you please send a diff instead of a whole file? (git diff <file1>
> <file2> > diff.diff ... see man git-diff)
Yes, Raju, please see the file, Documentation/SubmittingPatches for how
to do this properly.
Also, does your updated driver work properly for you? It would be good
to have proper RTS support in the pl2303 driver, but I thought that the
driver already supported this?
thanks,
greg k-h
next prev parent reply other threads:[~2010-08-19 14:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100819055329.M29689@admin-gateway.ncra.tifr.res.in>
[not found] ` <20100819061525.M24093@admin-gateway.ncra.tifr.res.in>
2010-08-19 7:38 ` Regarding USB-Serial Device driver Marek Vasut
2010-08-19 14:18 ` Greg KH [this message]
2010-08-20 3:42 ` Raju Rameshwar Uprade
2010-08-20 3:56 ` Greg KH
2010-08-20 6:56 ` Raju Rameshwar Uprade
2010-08-20 15:39 ` Greg KH
[not found] ` <AANLkTin8AiOj4CST5Dr_icnY4MugG1mhgP7=c1jgcJcA@mail.gmail.com>
2010-08-31 4:05 ` Greg KH
2010-09-07 6:14 Regarding USB-serial device driver Raju Rameshwar Uprade
2010-09-07 6:59 ` Greg KH
[not found] ` <20100907114913.M69542@admin-gateway.ncra.tifr.res.in>
2010-09-08 3:41 ` Raju Rameshwar Uprade
2010-09-08 6:17 ` Greg KH
2010-09-08 8:51 ` Raju Rameshwar Uprade
-- strict thread matches above, loose matches on Subject: below --
2010-08-19 6:28 Regarding USB-Serial Device driver Raju Rameshwar Uprade
2010-08-19 13:09 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819141812.GA12375@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=maxinbjohn@gmail.com \
--cc=orest.bond@outpostembedded.com \
--cc=rajsingh@ncra.tifr.res.in \
--cc=vijaykumar@zilogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).