public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
	uclinux-dev@uclinux.org, linux-kernel@vger.kernel.org
Subject: Re: nommu vm_get_page_prot and framebuffer drivers in 2.6.36-rc1
Date: Thu, 19 Aug 2010 11:02:45 -0400	[thread overview]
Message-ID: <20100819150245.GC9485@phenom.dumpdata.com> (raw)
In-Reply-To: <AANLkTi=VzruV3RYLTwKnC0bYtR7fSKzGehV=LLzoicXE@mail.gmail.com>

On Wed, Aug 18, 2010 at 03:21:35PM -0400, Mike Frysinger wrote:
> the recent commit c07fbfd17e614a76b194f371c5331e21e6cffb54 added a

Next time please do write to the folks that are on the Signed-off-by
list on the patch.

> call to vm_get_page_prot() in drivers/video/fbmem.c.  but this
> function doesnt exist for nommu.  so obviously we get:
> ERROR: "vm_get_page_prot" [drivers/video/fb.ko] undefined!

Duh!
> 
> looking a bit through mm/, i guess we should stub this out to 0 ?

Yes. Could you create a patch for this, please?

> #define vm_page_prot(x) 0
> -mike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

      reply	other threads:[~2010-08-19 15:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 19:21 nommu vm_get_page_prot and framebuffer drivers in 2.6.36-rc1 Mike Frysinger
2010-08-19 15:02 ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100819150245.GC9485@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox