* nommu vm_get_page_prot and framebuffer drivers in 2.6.36-rc1
@ 2010-08-18 19:21 Mike Frysinger
2010-08-19 15:02 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-08-18 19:21 UTC (permalink / raw)
To: David Howells; +Cc: uclinux-dev, linux-kernel
the recent commit c07fbfd17e614a76b194f371c5331e21e6cffb54 added a
call to vm_get_page_prot() in drivers/video/fbmem.c. but this
function doesnt exist for nommu. so obviously we get:
ERROR: "vm_get_page_prot" [drivers/video/fb.ko] undefined!
looking a bit through mm/, i guess we should stub this out to 0 ?
#define vm_page_prot(x) 0
-mike
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: nommu vm_get_page_prot and framebuffer drivers in 2.6.36-rc1
2010-08-18 19:21 nommu vm_get_page_prot and framebuffer drivers in 2.6.36-rc1 Mike Frysinger
@ 2010-08-19 15:02 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2010-08-19 15:02 UTC (permalink / raw)
To: Mike Frysinger; +Cc: David Howells, uclinux-dev, linux-kernel
On Wed, Aug 18, 2010 at 03:21:35PM -0400, Mike Frysinger wrote:
> the recent commit c07fbfd17e614a76b194f371c5331e21e6cffb54 added a
Next time please do write to the folks that are on the Signed-off-by
list on the patch.
> call to vm_get_page_prot() in drivers/video/fbmem.c. but this
> function doesnt exist for nommu. so obviously we get:
> ERROR: "vm_get_page_prot" [drivers/video/fb.ko] undefined!
Duh!
>
> looking a bit through mm/, i guess we should stub this out to 0 ?
Yes. Could you create a patch for this, please?
> #define vm_page_prot(x) 0
> -mike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-19 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18 19:21 nommu vm_get_page_prot and framebuffer drivers in 2.6.36-rc1 Mike Frysinger
2010-08-19 15:02 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox