linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: callchain sampling bug in perf?
Date: Thu, 19 Aug 2010 12:04:22 -0300	[thread overview]
Message-ID: <20100819150422.GA325@ghostprotocols.net> (raw)
In-Reply-To: <20100819085700.GB8782@infradead.org>

Em Thu, Aug 19, 2010 at 04:57:01AM -0400, Christoph Hellwig escreveu:
> On Thu, Aug 19, 2010 at 02:57:22AM +0200, Frederic Weisbecker wrote:
> > Hmm, against which tree are you running? I've just tested callchains
> > record on random kprobe based tracepoint and it seemed to work well
> > on report.
> 
> It's 2.6.36-rc1 + a few filesystem related changes.
> 
> > Could you send me your perf.data and also the resulting archive
> > after the following command: "perf archive" ?
> 
> Both attached.

[acme@doppio tmp]$ tar xvf perf.data.tar.bz2 -C ~/.debug
.build-id/36/4300f12afee3dd5b1a87269d60de586f6b61ce
[kernel.kallsyms]/364300f12afee3dd5b1a87269d60de586f6b61ce
[acme@doppio tmp]$
[acme@doppio tmp]$ cat /home/acme/.perfconfig 
[tui]

	report=off
[acme@doppio tmp]$ perf report
# Events: 11K cycles
#
# Overhead       Command      Shared Object     Symbol
# ........  ............  .................  .........
#
    61.70%        python  [kernel.kallsyms]  [k] xlog_sync
    24.05%     flush-9:1  [kernel.kallsyms]  [k] xlog_sync
     7.99%          sync  [kernel.kallsyms]  [k] xlog_sync
     2.94%  xfssyncd/md1  [kernel.kallsyms]  [k] xlog_sync
     1.54%  compilebench  [kernel.kallsyms]  [k] xlog_sync
     1.31%            sh  [kernel.kallsyms]  [k] xlog_sync
     0.23%         :3500  [kernel.kallsyms]  [k] xlog_sync
     0.17%         :3496  [kernel.kallsyms]  [k] xlog_sync
     0.06%         :3570  [kernel.kallsyms]  [k] xlog_sync
     0.01%         :3590  [kernel.kallsyms]  [k] xlog_sync


#
# (For a higher level overview, try: perf report --sort comm,dso)
#
[acme@doppio tmp]$

# yeah, I need to do what we discussed and make tui activation on the command
# line, this use case proves it, if it needed proving usefulness at all :-)

[acme@doppio tmp]$ cat /home/acme/.perfconfig 
[tui]

	report=on

[acme@doppio tmp]$ perf report

http://vger.kernel.org/~acme/perf/perf-report-tui-callchain-xlog_sync.png

So it seems to work (you tell me if the callchains make sense), and the problem
is just on the stdio based callchain rendering.

Frederic, so it doesn't look like anything in the kernel, just a tools/perf/
problem.

I found some issues on the TUI as well, please press the left key some times
after expanding some callchains, so that the window can be resized, your workload
has just a few top level entries, so the window initially is small, I need to
take into account the (to be expanded) callchains and size it properly.

- Arnaldo

  parent reply	other threads:[~2010-08-19 15:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-15 22:53 callchain sampling bug in perf? Christoph Hellwig
2010-08-19  0:57 ` Frederic Weisbecker
     [not found]   ` <20100819085700.GB8782@infradead.org>
2010-08-19 15:04     ` Arnaldo Carvalho de Melo [this message]
2010-08-20  9:16       ` Christoph Hellwig
2010-08-20 19:12         ` Arnaldo Carvalho de Melo
2010-08-21  2:29           ` Frederic Weisbecker
2010-08-21 14:44           ` Christoph Hellwig
2010-08-21  2:47         ` Frederic Weisbecker
2010-08-21 14:42           ` Christoph Hellwig
2010-08-21 14:46             ` Christoph Hellwig
2010-08-22  5:20               ` Frederic Weisbecker
2010-08-22  8:11                 ` Christoph Hellwig
2010-08-22  0:49             ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100819150422.GA325@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).