* [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit()
@ 2010-08-19 6:40 Axel Lin
2010-08-20 9:26 ` Liam Girdwood
2010-08-20 9:37 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2010-08-19 6:40 UTC (permalink / raw)
To: linux-kernel; +Cc: Ian Molton, Liam Girdwood, Mark Brown
In e740_init(), we call gpio_request() for
GPIO_E740_MIC_ON, GPIO_E740_AMP_ON and GPIO_E740_WM9705_nAVDD2.
We should free the these gpio accordingly in e740_exit().
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/pxa/e740_wm9705.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/pxa/e740_wm9705.c b/sound/soc/pxa/e740_wm9705.c
index 7cd2f89..515faeb 100644
--- a/sound/soc/pxa/e740_wm9705.c
+++ b/sound/soc/pxa/e740_wm9705.c
@@ -200,6 +200,9 @@ free_mic_amp_gpio:
static void __exit e740_exit(void)
{
platform_device_unregister(e740_snd_device);
+ gpio_free(GPIO_E740_WM9705_nAVDD2);
+ gpio_free(GPIO_E740_AMP_ON);
+ gpio_free(GPIO_E740_MIC_ON);
}
module_init(e740_init);
--
1.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit()
2010-08-19 6:40 [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit() Axel Lin
@ 2010-08-20 9:26 ` Liam Girdwood
2010-08-20 9:37 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-08-20 9:26 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Ian Molton, Mark Brown
On Thu, 2010-08-19 at 14:40 +0800, Axel Lin wrote:
> In e740_init(), we call gpio_request() for
> GPIO_E740_MIC_ON, GPIO_E740_AMP_ON and GPIO_E740_WM9705_nAVDD2.
> We should free the these gpio accordingly in e740_exit().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit()
2010-08-19 6:40 [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit() Axel Lin
2010-08-20 9:26 ` Liam Girdwood
@ 2010-08-20 9:37 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-08-20 9:37 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Ian Molton, Liam Girdwood
On Thu, Aug 19, 2010 at 02:40:25PM +0800, Axel Lin wrote:
> In e740_init(), we call gpio_request() for
> GPIO_E740_MIC_ON, GPIO_E740_AMP_ON and GPIO_E740_WM9705_nAVDD2.
> We should free the these gpio accordingly in e740_exit().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-20 9:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-19 6:40 [PATCH] ASoC: e740_wm9705 - free gpio in e740_exit() Axel Lin
2010-08-20 9:26 ` Liam Girdwood
2010-08-20 9:37 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox