* [Patch] makefile: not need to regenerate kernel.release file when make kernelrelease
@ 2010-08-20 9:36 Amerigo Wang
2010-08-20 11:57 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Amerigo Wang @ 2010-08-20 9:36 UTC (permalink / raw)
To: linux-kernel; +Cc: Brice Goglin, akpm, linux-kbuild, Amerigo Wang, Michal Marek
Brice reported that 'kernelrelease' has a dependence on include/config/kernel.release,
causes this file to be regenerated every time when invoke it. It doesn't have to.
Reported-by: Brice Goglin <Brice.Goglin@inria.fr>
Tested-by: Brice Goglin <Brice.Goglin@inria.fr>
Signed-off-by: WANG Cong <amwang@redhat.com>
---
diff --git a/Makefile b/Makefile
index f3bdff8..25da252 100644
--- a/Makefile
+++ b/Makefile
@@ -1408,8 +1408,8 @@ checkstack:
$(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
$(PERL) $(src)/scripts/checkstack.pl $(CHECKSTACK_ARCH)
-kernelrelease: include/config/kernel.release
- @echo $(KERNELRELEASE)
+kernelrelease:
+ @echo "$(KERNELVERSION)$$($(CONFIG_SHELL) $(srctree)/scripts/setlocalversion $(srctree))"
kernelversion:
@echo $(KERNELVERSION)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] makefile: not need to regenerate kernel.release file when make kernelrelease
2010-08-20 9:36 [Patch] makefile: not need to regenerate kernel.release file when make kernelrelease Amerigo Wang
@ 2010-08-20 11:57 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2010-08-20 11:57 UTC (permalink / raw)
To: Amerigo Wang; +Cc: linux-kernel, Brice Goglin, akpm, linux-kbuild
On 20.8.2010 11:36, Amerigo Wang wrote:
> Brice reported that 'kernelrelease' has a dependence on include/config/kernel.release,
> causes this file to be regenerated every time when invoke it. It doesn't have to.
>
> Reported-by: Brice Goglin<Brice.Goglin@inria.fr>
> Tested-by: Brice Goglin<Brice.Goglin@inria.fr>
> Signed-off-by: WANG Cong<amwang@redhat.com>
Thanks, applied. And sorry for breaking your previous patch.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-20 12:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-20 9:36 [Patch] makefile: not need to regenerate kernel.release file when make kernelrelease Amerigo Wang
2010-08-20 11:57 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox