From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Namhyung Kim <namhyung@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] initramfs: remove sparse warnings
Date: Fri, 20 Aug 2010 13:00:02 +0100 [thread overview]
Message-ID: <20100820120001.GR31363@ZenIV.linux.org.uk> (raw)
In-Reply-To: <201008191638.23248.arnd@arndb.de>
On Thu, Aug 19, 2010 at 04:38:23PM +0200, Arnd Bergmann wrote:
> On Thursday 19 August 2010, Namhyung Kim wrote:
> > This patchset removes most of sparse warnings in init/initramfs.c.
> > Current implementation of initramfs relies on syscall service rountins heavily
> > so it requires many of arguments to be __user address space pointers but, in
> > most cases, were missing proper markups. This patchset tries to fix those at
> > a minimum change.
>
> I'm skeptical about this, you are adding obviously incorrect annotations
> to the code to make something work that was written without the awareness
> for address spaces.
>
> A better way would be to call path_lookup or kern_path to look up the
> path and pass that to a lower-level file I/O function.
No. This code should *NOT* use the VFS guts, TYVM. The whole fscking point
is that this puppy is a sequence of plain vanilla syscalls, ideally run
simply in userland thread. We used to have a magical mystery shite in there
and it had been a huge PITA.
next prev parent reply other threads:[~2010-08-20 12:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 3:37 [PATCH 0/4] initramfs: remove sparse warnings Namhyung Kim
2010-08-19 3:37 ` [PATCH 1/4] initramfs: refactor clean_path() Namhyung Kim
2010-08-19 3:37 ` [PATCH 2/4] initramfs: mark dirp as a __user pointer on clean_rootfs() Namhyung Kim
2010-08-19 3:37 ` [PATCH 3/4] initramfs: mark collect buffers as __user pointers Namhyung Kim
2010-08-19 3:37 ` [PATCH 4/4] initramfs: add missing __user markup Namhyung Kim
2010-08-19 14:38 ` [PATCH 0/4] initramfs: remove sparse warnings Arnd Bergmann
2010-08-19 16:57 ` Namhyung Kim
2010-08-20 12:00 ` Al Viro [this message]
2010-08-20 15:36 ` Namhyung Kim
2010-08-22 20:33 ` Arnd Bergmann
2010-08-23 14:59 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820120001.GR31363@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).