From: Don Zickus <dzickus@redhat.com>
To: Lin Ming <ming.m.lin@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] lockup_detector: Make callback function static
Date: Fri, 20 Aug 2010 08:19:17 -0400 [thread overview]
Message-ID: <20100820121917.GC4879@redhat.com> (raw)
In-Reply-To: <1282273431.16443.32.camel@minggr.sh.intel.com>
On Fri, Aug 20, 2010 at 11:03:51AM +0800, Lin Ming wrote:
> watchdog_overflow_callback is only used in kernel/watchdog.c.
Acked-by: Don Zickus <dzickus@redhat.com>
>
> Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> ---
> kernel/watchdog.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 613bc1f..b60e2a8 100644
> --- a/kernel/watchdog.c
> +++ b/kernel/watchdog.c
> @@ -202,7 +202,7 @@ static struct perf_event_attr wd_hw_attr = {
> };
>
> /* Callback function for perf event subsystem */
> -void watchdog_overflow_callback(struct perf_event *event, int nmi,
> +static void watchdog_overflow_callback(struct perf_event *event, int nmi,
> struct perf_sample_data *data,
> struct pt_regs *regs)
> {
>
>
next prev parent reply other threads:[~2010-08-20 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 3:03 [PATCH] lockup_detector: Make callback function static Lin Ming
2010-08-20 12:19 ` Don Zickus [this message]
2010-08-20 12:41 ` [tip:core/locking] " tip-bot for Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820121917.GC4879@redhat.com \
--to=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox