From: Fenghua Yu <fenghua.yu@intel.com>
To: "mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Joerg.Roedel@amd.com" <Joerg.Roedel@amd.com>,
"maciej.rutecki@gmail.com" <maciej.rutecki@gmail.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
"sergey.senozhatsky@gmail.com" <sergey.senozhatsky@gmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>
Cc: "linux-tip-commits@vger.kernel.org" <linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:x86/urgent] x86, hwmon: Fix unsafe smp_processor_id() in thermal_throttle_add_dev
Date: Fri, 20 Aug 2010 22:51:52 -0700 [thread overview]
Message-ID: <20100821055152.GD22602@linux-os.sc.intel.com> (raw)
In-Reply-To: <tip-51e3c1b558b31b11bf5fc66d3c6f5adacf3573f7@git.kernel.org>
On Fri, Aug 20, 2010 at 09:43:03PM -0700, tip-bot for Sergey Senozhatsky wrote:
> Commit-ID: 51e3c1b558b31b11bf5fc66d3c6f5adacf3573f7
> Gitweb: http://git.kernel.org/tip/51e3c1b558b31b11bf5fc66d3c6f5adacf3573f7
> Author: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> AuthorDate: Fri, 20 Aug 2010 10:36:34 +0300
> Committer: H. Peter Anvin <hpa@zytor.com>
> CommitDate: Fri, 20 Aug 2010 19:56:00 -0700
>
> x86, hwmon: Fix unsafe smp_processor_id() in thermal_throttle_add_dev
>
> Fix BUG: using smp_processor_id() in preemptible thermal_throttle_add_dev.
> We know the cpu number when calling thermal_throttle_add_dev, so we can
> remove smp_processor_id call in thermal_throttle_add_dev by supplying
> the cpu number as argument.
>
> This should resolve kernel bugzilla 16615/16629.
The fix is right. Current thermal_throttle_add_dev checks local processor to
determine PTS and PLN features on another processor. Logically that is wrong.
Thanks.
-Fenghua
prev parent reply other threads:[~2010-08-21 5:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 9:11 fix BUG: using smp_processor_id() in preemptible code (resend) Sergey Senozhatsky
2010-08-19 15:04 ` Maciej Rutecki
2010-08-19 17:03 ` Roedel, Joerg
2010-08-19 21:46 ` H. Peter Anvin
2010-08-20 7:36 ` [PATCH] fix BUG using smp_processor_id() in preemptible thermal_throttle_add_dev Sergey Senozhatsky
2010-08-21 4:43 ` [tip:x86/urgent] x86, hwmon: Fix unsafe smp_processor_id() in thermal_throttle_add_dev tip-bot for Sergey Senozhatsky
2010-08-21 5:51 ` Fenghua Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100821055152.GD22602@linux-os.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=Joerg.Roedel@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=mingo@redhat.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox