From: Greg KH <gregkh@suse.de>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] firmware: fix request_firmware() error handling
Date: Sun, 22 Aug 2010 10:10:03 -0700 [thread overview]
Message-ID: <20100822171003.GA8658@suse.de> (raw)
In-Reply-To: <1282489770-2757-1-git-send-email-penberg@kernel.org>
On Sun, Aug 22, 2010 at 06:09:30PM +0300, Pekka Enberg wrote:
> If _request_firmware() fails and we do release_firmware(), update the pointer
> pointed to by 'firmware_p' so that we don't return a free'd pointer to the
> caller.
>
> This patch fixes a boot-time crash on my MacBook that's caused by failing
> isight_firmware_load(). The bug was introduced in commit f8a4bd34 ("firmware
> loader: embed device into firmware_priv structure") and makes 2.6.36-rc1
> unusable on my box.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>
Thanks, already in my tree and linux-next and will be going to Linus on
Monday.
greg k-h
prev parent reply other threads:[~2010-08-22 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 15:09 [PATCH] firmware: fix request_firmware() error handling Pekka Enberg
2010-08-22 17:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100822171003.GA8658@suse.de \
--to=gregkh@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox