From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Hiremath, Vaibhav" <hvaibhav@ti.com>
Cc: "Balbi Felipe (Nokia-MS/Helsinki)" <felipe.balbi@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"byron.bbradley@gmail.com" <byron.bbradley@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support
Date: Mon, 23 Aug 2010 09:29:57 +0300 [thread overview]
Message-ID: <20100823062957.GA1068@nokia.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044F1252C6@dbde02.ent.ti.com>
Hi,
please break your lines at 80-characters. Also the [Hiremath, Vaibhav]
is unnecessary.
On Mon, Aug 23, 2010 at 06:58:42AM +0200, ext Hiremath, Vaibhav wrote:
>> don't you need some locking on the irq handler ? a mutex maybe ? Just
>> wondering...
>>
>[Hiremath, Vaibhav] Yes definitely we do need locking here, I thought
>of adding locking mechanism in subsequent patch, does it makes sense?
so you add a buggy patch and fix it later ? If you already know it's
buggy, why not changing the patch that adds the bug ?
--
balbi
DefectiveByDesign.org
next prev parent reply other threads:[~2010-08-23 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 12:30 [PATCH-V2 1/3] RTC:s35390a: Add Alarm interrupt support hvaibhav
2010-08-21 14:05 ` Felipe Balbi
2010-08-23 4:58 ` Hiremath, Vaibhav
2010-08-23 6:29 ` Felipe Balbi [this message]
2010-08-23 10:34 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823062957.GA1068@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=byron.bbradley@gmail.com \
--cc=hvaibhav@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox