From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370Ab0HWGv1 (ORCPT ); Mon, 23 Aug 2010 02:51:27 -0400 Received: from mga11.intel.com ([192.55.52.93]:57817 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751978Ab0HWGvY (ORCPT ); Mon, 23 Aug 2010 02:51:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.56,256,1280732400"; d="scan'208";a="599190963" Date: Mon, 23 Aug 2010 14:51:20 +0800 From: Wu Fengguang To: Andrew Morton Cc: Tiago Maluta , Michal Marek , LKML , Sam Ravnborg , WANG Cong Subject: [PATCH -mm V4] kbuild: fix reading CROSS_COMPILE from .config Message-ID: <20100823065120.GA23688@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix compile error $ ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- make ... cc1: error: unrecognized command line option "-m64" cc1: error: unrecognized command line option "-mno-red-zone" cc1: error: unrecognized command line option "-mcmodel=kernel" cc1: error: unrecognized command line option "-maccumulate-outgoing-args" The error was introduced by patch kbuild-fix-config_cross_compile-issue-in-config.patch: -CROSS_COMPILE ?= $(CONFIG_CROSS_COMPILE:"%"=%) +CROSS_COMPILE := $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2) That patch does two things: 1) It grep for CONFIG_CROSS_COMPILE because we may not have incldued .config 2) It no longer pick up CROSS_COMPILE from the environment. Traditionally we have picked up ARCH and CROSS_COMPILE from the environment, hence the use of "?=". "?=" says - perform this assignment unless lhs is already defined. And lhs may be already defined is we have the symbol defined in the environment. I think the original submitter changed from ?= to := without realizing this. So the patch should be adjusted to use ?= again before it is applied. Cc: Tiago Maluta Cc: Michal Marek Acked-by: WANG Cong Signed-off-by: Sam Ravnborg Signed-off-by: Wu Fengguang --- Andrew: it's an -mm tree only bug for now Sam: I copied so many of your nice comments to the changelog, so that I added your Signed-off-by :) diff --git a/Makefile b/Makefile index 276d642..a2d3ded 100644 --- a/Makefile +++ b/Makefile @@ -189,8 +189,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \ # Note: Some architectures assign CROSS_COMPILE in their arch/*/Makefile export KBUILD_BUILDHOST := $(SUBARCH) ARCH ?= $(SUBARCH) -CROSS_COMPILE ?= -CROSS_COMPILE := $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2) +CROSS_COMPILE ?= $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2) # Architecture as present in compile.h UTS_MACHINE := $(ARCH)