From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] regulator: max8998 - set max8998->num_regulators
Date: Mon, 23 Aug 2010 11:01:28 +0100 [thread overview]
Message-ID: <20100823100128.GE6061@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1282462009.2989.2.camel@phoenix>
On Sun, Aug 22, 2010 at 03:26:49PM +0800, Axel Lin wrote:
> Set max8998->num_regulators = pdata->num_regulators,
> otherwise it's default value is 0.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
With a change like this it's good to note why things worked prior to the
change - my first thought was that it might be better to loose the
driver data copy entirely if we were fine with it being set to zero.
next prev parent reply other threads:[~2010-08-23 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 7:26 [PATCH] regulator: max8998 - set max8998->num_regulators Axel Lin
2010-08-23 10:01 ` Mark Brown [this message]
2010-08-24 14:01 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823100128.GE6061@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox