From: Matthew Wilcox <matthew@wil.cx>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Richard Cochran <richardcochran@gmail.com>,
john stultz <johnstul@us.ibm.com>,
linux-api@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] posix clocks: introduce syscall for clock tuning.
Date: Mon, 23 Aug 2010 07:43:30 -0600 [thread overview]
Message-ID: <20100823134330.GM12892@parisc-linux.org> (raw)
In-Reply-To: <201008231457.26690.arnd@arndb.de>
On Mon, Aug 23, 2010 at 02:57:26PM +0200, Arnd Bergmann wrote:
> > +static inline int common_clock_adj(const clockid_t which_clock, int ppb,
> > + struct timespec *tp)
> > +{
> > + return -EOPNOTSUPP;
> > +}
> > +
> > static int no_timer_create(struct k_itimer *new_timer)
> > {
> > return -EOPNOTSUPP;
>
> So we already return -EOPNOTSUPP in some cases? The man page does not document this.
> I wonder if we should change that to -EINVAL as well.
ENOTTY is the usual errno for "inappropriate ioctl for device". Due to
the way this patch has been chopped up, I can't tell if that's what is
intended here.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2010-08-23 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 8:15 [PATCH RFC 0/1] introduce a syscall for posix clock tuning Richard Cochran
2010-08-23 8:16 ` [PATCH 1/1] posix clocks: introduce syscall for " Richard Cochran
2010-08-23 8:22 ` Mike Frysinger
2010-08-23 8:52 ` Richard Cochran
2010-08-23 8:25 ` Bert Wesarg
2010-08-23 8:55 ` Richard Cochran
2010-08-23 12:57 ` Arnd Bergmann
2010-08-23 13:43 ` Matthew Wilcox [this message]
2010-08-23 14:46 ` Arnd Bergmann
2010-08-23 16:57 ` Roland McGrath
2010-08-23 20:41 ` john stultz
2010-08-27 11:24 ` Richard Cochran
2010-08-27 20:48 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823134330.GM12892@parisc-linux.org \
--to=matthew@wil.cx \
--cc=arnd@arndb.de \
--cc=johnstul@us.ibm.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox