From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754400Ab0HWQLI (ORCPT ); Mon, 23 Aug 2010 12:11:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44341 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585Ab0HWQLG (ORCPT ); Mon, 23 Aug 2010 12:11:06 -0400 Date: Mon, 23 Aug 2010 19:10:45 +0300 From: Gleb Natapov To: Christoph Lameter Cc: Avi Kivity , kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mingo@elte.hu, a.p.zijlstra@chello.nl, tglx@linutronix.de, hpa@zytor.com, riel@redhat.com, mtosatti@redhat.com Subject: Re: [PATCH v5 03/12] Add async PF initialization to PV guest. Message-ID: <20100823161045.GV10499@redhat.com> References: <1279553462-7036-1-git-send-email-gleb@redhat.com> <1279553462-7036-4-git-send-email-gleb@redhat.com> <4C729342.6070205@redhat.com> <20100823153549.GU10499@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2010 at 11:08:06AM -0500, Christoph Lameter wrote: > On Mon, 23 Aug 2010, Gleb Natapov wrote: > > > > The guest will have to align this on a 64 byte boundary, should this > > > be marked __aligned(64) here? > > > > > I do __aligned(64) when I declare variable of that type: > > > > static DEFINE_PER_CPU(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64); > > 64 byte boundary: You mean cacheline aligned? We have a special define for > that. > > DEFINE_PER_CPU_SHARED_ALIGNED IIRC I tried to use it and it does different alignment on 64/32 bit. The alignment here is part of guest/host interface so it should be the same on both. -- Gleb.