* [PATCH 12/18 v2] staging: crystalhd: call disable_pci_device() if pci_probe() failed
@ 2010-08-09 19:51 Kulikov Vasiliy
2010-08-23 17:47 ` Jarod Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-08-09 19:51 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Jarod Wilson, Manu Abraham, Scott Davilla,
Arnd Bergmann, devel, linux-kernel
Driver should call disable_pci_device() if it returns from pci_probe()
with error.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/crystalhd/crystalhd_lnx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
index fbb80f0..115e79b 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -570,6 +570,7 @@ static int __devinit chd_dec_pci_probe(struct pci_dev *pdev,
rc = chd_pci_reserve_mem(pinfo);
if (rc) {
BCMLOG_ERR("Failed to setup memory regions.\n");
+ pci_disable_device(pdev);
return -ENOMEM;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 12/18 v2] staging: crystalhd: call disable_pci_device() if pci_probe() failed
2010-08-09 19:51 [PATCH 12/18 v2] staging: crystalhd: call disable_pci_device() if pci_probe() failed Kulikov Vasiliy
@ 2010-08-23 17:47 ` Jarod Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Jarod Wilson @ 2010-08-23 17:47 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Kroah-Hartman, Manu Abraham, Scott Davilla,
Arnd Bergmann, devel, linux-kernel
On Mon, Aug 09, 2010 at 11:51:44PM +0400, Kulikov Vasiliy wrote:
> Driver should call disable_pci_device() if it returns from pci_probe()
> with error.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Looks fine by me.
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-23 18:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-09 19:51 [PATCH 12/18 v2] staging: crystalhd: call disable_pci_device() if pci_probe() failed Kulikov Vasiliy
2010-08-23 17:47 ` Jarod Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox