From: Daniel Mack <daniel@caiaq.de>
To: Dan Carpenter <error27@gmail.com>,
Anton Vorontsov <cbouatmailru@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] pda_power: remove unneeded assignment
Date: Mon, 23 Aug 2010 23:39:01 +0200 [thread overview]
Message-ID: <20100823213901.GJ17833@buzzloop.caiaq.de> (raw)
In-Reply-To: <20100823212103.GA7340@bicker>
On Mon, Aug 23, 2010 at 11:21:03PM +0200, Dan Carpenter wrote:
> We never use the "ret" value from this assignment, and also
> PTR_ERR(NULL) is zero. I looked at it and this driver is designed to
> accept a NULL value for "ac_draw". So there isn't a bug in the original
> code and we can just remove this confusing assignment.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Looks reasonable.
Acked-by: Daniel Mack <daniel@caiaq.de>
> diff --git a/drivers/power/pda_power.c b/drivers/power/pda_power.c
> index 69f8aa3..63a6a4d 100644
> --- a/drivers/power/pda_power.c
> +++ b/drivers/power/pda_power.c
> @@ -279,7 +279,6 @@ static int pda_power_probe(struct platform_device *pdev)
> if (IS_ERR(ac_draw)) {
> dev_dbg(dev, "couldn't get ac_draw regulator\n");
> ac_draw = NULL;
> - ret = PTR_ERR(ac_draw);
> }
>
> if (pdata->is_ac_online) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2010-08-23 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 21:21 [patch] pda_power: remove unneeded assignment Dan Carpenter
2010-08-23 21:39 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823213901.GJ17833@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=cbouatmailru@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox