From: Andreas Gruenbacher <agruen@suse.de>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] fanotify: flush outstanding perm requests on group destroy
Date: Tue, 24 Aug 2010 03:13:11 +0200 [thread overview]
Message-ID: <201008240313.11593.agruen@suse.de> (raw)
In-Reply-To: <1282523830-27751-1-git-send-email-eparis@redhat.com>
On Monday 23 August 2010 02:37:07 Eric Paris wrote:
> When an fanotify listener is closing it may cause a deadlock between the
> listener and the original task doing an fs operation. If the original task
> is waiting for a permissions response it will be holding the srcu lock.
> The listener cannot clean up and exit until after that srcu lock is
> syncronized. Thus deadlock. The fix introduced here is to stop accepting
> new permissions events when a listener is shutting down and to grant
> permission for all outstanding events. Thus the original task will
> eventually release the srcu lock and the listener can complete shutdown.
This seems to work now.
The one remaining issue is that processes blocked on perm events cannot be
killed even with SIGKILL. I don't know how hard it will be to fix this.
Thanks,
Andreas
next prev parent reply other threads:[~2010-08-24 1:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 0:37 [PATCH 1/4] fanotify: flush outstanding perm requests on group destroy Eric Paris
2010-08-23 0:37 ` [PATCH 2/4] fanotify: drop duplicate pr_debug statement Eric Paris
2010-08-23 0:37 ` [PATCH 3/4] fanotify: resize pid and reorder structure Eric Paris
2010-08-23 0:37 ` [PATCH 4/4] fanotify: drops the packed attribute from userspace event metadata Eric Paris
2010-08-23 16:13 ` Andreas Gruenbacher
2010-08-24 1:13 ` Andreas Gruenbacher [this message]
2010-08-24 8:49 ` [PATCH 1/4] fanotify: flush outstanding perm requests on group destroy Tvrtko Ursulin
2010-08-24 9:36 ` Andreas Gruenbacher
2010-08-24 9:51 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008240313.11593.agruen@suse.de \
--to=agruen@suse.de \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox