public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	akpm@linux-foundation.org, mingo@elte.hu, peterz@infradead.org
Subject: Re: [RFC PATCH 1/3] timer: fix comments of try_to_del_timer_sync()
Date: Tue, 24 Aug 2010 20:49:58 +0800	[thread overview]
Message-ID: <20100824124958.GA3070@zhy> (raw)
In-Reply-To: <20100824121109.GA13061@redhat.com>

On Tue, Aug 24, 2010 at 02:11:09PM +0200, Oleg Nesterov wrote:
> On 08/24, Yong Zhang wrote:
> >
> > From: Yong Zhang <yong.zhang@windriver.com>
> >
> > In commit fd450b7318b75343fd76b3d95416853e34e72c95, it was saying
> > try_to_del_timer_sync() can be used in interrupt context.
> 
> Yes, but not in UP case.

Yeah, but in UP case there is no try_to_del_timer_sync(), it's redefined
to del_timer().

> 
> Please remove "#ifdef CONFIG_SMP" from set_running_timer(), then iirc
> it can be used from irq.

I have noticed your comments in the commit log, but I think it's about
introducing the same semantic of try_to_del_timer_sync() on UP as well
as SMP. But this patch is focusing on the current code(SMP special).
Not about realizing try_to_del_timer_sync() on UP case. Do we need
to do that?

Thanks,
Yong

  reply	other threads:[~2010-08-24 12:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24  6:58 [RFC PATCH 0/3] timer: patchset focus on del_timer_sync() Yong Zhang
2010-08-24  6:58 ` [RFC PATCH 1/3] timer: fix comments of try_to_del_timer_sync() Yong Zhang
2010-08-24 12:11   ` Oleg Nesterov
2010-08-24 12:49     ` Yong Zhang [this message]
2010-08-24 16:31       ` Oleg Nesterov
2010-08-25  1:56         ` Yong Zhang
2010-08-24  6:58 ` [RFC PATCH 2/3] timer: del_timer_sync() can be used in softirq context Yong Zhang
2010-08-24  6:58 ` [RFC PATCH 3/3] timer: warn when del_timer_sync() used in hardirq context Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100824124958.GA3070@zhy \
    --to=yong.zhang0@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox