Re: [PATCH] Add intel drm blacklist to intel_opregion_present detect

Joey Lee
2010-07-13T08:13:46Z

Hi Matthew,

First, thank's for your kindly suggestion.

於 一，2010-07-12 於 16:19 +0100，Matthew Garrett 提到：
>
> > On the other hand, the Poulsbo is a old and stop ship chip, do we still
> > want to add a special driver for it?
>
> Yeah, that's my concern. There's millions of things in the wild and
> Intel continue to refuse to take responsibility for them, so it's not
> clear to me that it's worth putting the effort into writing a "correct"
> driver.
>

Yes, fully agreed!

> > Thank's for your remind, I fully agreed cann't guarantee all poulsbo
> > systems have working acpi method. But, I am sure the MSI U110/U115 have
> > workable acpi backlight method.
> > Do you think it's good to put the special DMI detection in msi-laptop
> > driver to enable the the acpi backlight control by call
> > acpi_video_register in acpi video? But will cause msi-laptop driver
> > dependency to acpi video driver.
>
> Mm. Well, we *know* that opregion won't work on Poulsbo as is (even
> Intel's driver doesn't implement it), so there's no way this patch can
> make things any worse. On the other hand, if anyone ships an OS with
> this hack *and* a native psb driver, I'm going to look sad for some
> time.
>

Please then me add the MSI U110/U115 support in msi-laptop driver. I am
sure the acpi baclight method works fine on U110/U115 and I hope the
_REAL_ opensource kernel user will not have a invalid backlight control
function.

For the native psb driver, if have anyone want to ship it with newest
msi-laptop driver, then he must need take care anything in KMP, like:
disable msi-laptop or put it to modprobe blacklist.
Because the native psb driver doesn't not included in kernel mainline.

On the other hand, the Poulsbo already stop to chip, there will not have
many machine ship the native psb driver with newest msi-laptop.

Thank's a lot!
Joey Lee