Re: [PATCH] Add intel drm blacklist to intel_opregion_present detect

Greg KH
2010-08-24T14:55:29Z

On Tue, Aug 24, 2010 at 03:22:19PM +0100, Matthew Garrett wrote:
> Erm. Sorry about that - I just realised that there's actually a fairly
> significant problem with it :) Right now you'll perform the register
> call unconditionally on module load. You need to make sure that there's
> actually Poulsbo hardware in the system, either by registering as a
> proper PCI driver and calling acpi_video_register in your probe function
> (and unregister in your remove function) or walking the PCI device list
> looking for a psb device.

Ick, don't walk the pci device list, just register a "real" pci device
and do it that way, it's much simpler and plays nicer with the driver
model and the rest of the kernel.

thanks,

greg k-h