public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sitsofe Wheeler <sitsofe@yahoo.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH 1/2] drm/i915: Revert wait for vblank to prevent X refresh issues
Date: Tue, 24 Aug 2010 16:41:55 +0100	[thread overview]
Message-ID: <20100824154154.GA10473@sucs.org> (raw)
In-Reply-To: <20100824095535.GA14020@sucs.org>

In commit 9d0498a2bf7455159b317f19531a3e5db2ecc9c4 20ms waits were
converted into vblank waits. One of these caused tearing, mode detection
and redraw issues on an EeePC 900 with a more recent intel userspace (
http://lkml.org/lkml/2010/8/23/432 ). Restoring the 20ms wait resolves
the issue.
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 23157e1..116d938 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4539,7 +4539,7 @@ struct drm_crtc *intel_get_load_detect_pipe(struct intel_encoder *intel_encoder,
 		encoder_funcs->commit(encoder);
 	}
 	/* let the connector get through one full cycle before testing */
-	intel_wait_for_vblank(dev, intel_crtc->pipe);
+	msleep(20);
 
 	return crtc;
 }
-- 
1.7.1


  reply	other threads:[~2010-08-24 15:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23 23:35 [REGRESSION, i915]: Periodic stalls with 2.6.36-rc2 Sitsofe Wheeler
2010-08-24  0:12 ` Chris Wilson
2010-08-24  7:57   ` Sitsofe Wheeler
2010-08-24  8:16     ` Chris Wilson
2010-08-24  8:49       ` Sitsofe Wheeler
2010-08-24  9:00         ` Chris Wilson
2010-08-24  9:55           ` [REGRESSION, BISECTED, " Sitsofe Wheeler
2010-08-24 15:41             ` Sitsofe Wheeler [this message]
2010-08-24 15:53             ` [PATCH 1/2] drm/i915: Revert wait for vblank to prevent X refresh issues Sitsofe Wheeler
2010-08-24 15:56               ` [PATCH 2/2] drm/i915: Revert extra intel_wait_for_vblank to prevent stalls Sitsofe Wheeler
2010-08-24 16:35                 ` Jesse Barnes
2010-08-24 16:39               ` [PATCH 1/2] drm/i915: Revert wait for vblank to prevent X refresh issues Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100824154154.GA10473@sucs.org \
    --to=sitsofe@yahoo.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox