Re: [PATCH] drm/i915/tv: After disabling the pipe, use wait_for_vblank_off()

Kan-Ru Chen
2010-08-25T09:51:10Z

On Wed, 25 Aug 2010 01:06:36 +0200, Ivan Bulatovic <combuster@gmx.com> wrote:
> On Tue, 2010-08-24 at 22:52 +0100, Chris Wilson wrote:
> > On Tue, 24 Aug 2010 23:08:50 +0200, Ivan Bulatovic <combuster@gmx.com> wrote:
> > > Unfotunately I still get TV connection detected :(
> >
> > Jesse spotted the root cause and Linus has now pushed that fix for
> > intel_wait_for_vblank() out. This is just a very minor bug in comparison.
> > Can you please test against linus/master and check that resolves the
> > spurious TV detection for you?
> > Thanks.
> >
> > --
> > Chris Wilson, Intel Open Source Technology Centre
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
> Spurious TV detection is still here and + I have a new problem with
> resolution in init3 when KMS fires up, it occupies only 1/3rd of the
> screen when booting.

Same here with my Acer 3810T, Intel GM45, the kernel was built from git pulled today.

v2.6.36-rc2-203-g502adf5

TV1 connected (normal left inverted right x axis y axis)
848x480 30.0 +
640x480 30.0 +
1024x768 30.0
800x600 30.0

and the fb only occupies 1/3rd of the screen, the fbset output

mode "848x480"
geometry 848 480 1366 768 32
timings 0 0 0 0 0 0 0
rgba 8/16,8/8,8/0,0/0
endmode

-Kanru
>
> I've tried patching the kernel I used for testing so far with that one
> liner and I've tried without patches we tried so far (git pull on a
> clean linux-git) and the symptoms are the same on both of them.
>
> So
> - PIPE_VBLANK_INTERRUPT_STATUS) == 0,
> + PIPE_VBLANK_INTERRUPT_STATUS),
> in intel_display.c doesn't fix the issue, plus it brings a new one in my
> case.
>
> /edit: had to remove linux-gfx from cc or mail wouldn't send otherwise