From: Dan Carpenter <error27@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/5] drivers/char/agp: Eliminate memory leak
Date: Tue, 24 Aug 2010 19:16:44 +0200 [thread overview]
Message-ID: <20100824171644.GL29330@bicker> (raw)
In-Reply-To: <Pine.LNX.4.64.1008241639130.15172@ask.diku.dk>
On Tue, Aug 24, 2010 at 04:39:29PM +0200, Julia Lawall wrote:
>
> - error = agp_add_bridge(bridge);
> + return agp_add_bridge(bridge);
>
error = agp_add_bridge(bridge);
if (error)
goto fail;
return 0;
> fail:
> + kfree(fake_bridge_dev);
> return error;
> }
>
regards,
dan carpenter
next prev parent reply other threads:[~2010-08-24 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 14:39 [PATCH 4/5] drivers/char/agp: Eliminate memory leak Julia Lawall
2010-08-24 17:16 ` Dan Carpenter [this message]
2010-08-24 19:46 ` Julia Lawall
2010-08-24 20:20 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824171644.GL29330@bicker \
--to=error27@gmail.com \
--cc=airlied@linux.ie \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox