From: Arnd Bergmann <arnd@arndb.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks
Date: Tue, 24 Aug 2010 17:26:08 +0200 [thread overview]
Message-ID: <201008241726.08797.arnd@arndb.de> (raw)
In-Reply-To: <20100824150655.GB2160@osiris.boeblingen.de.ibm.com>
On Tuesday 24 August 2010, Heiko Carstens wrote:
> > (Taking Martin and Heiko on Cc for s390)
> >
> > I'd strongly suggest making the behavior the same for everyone. It should
> > be fairly easy to make sure none of these warnings ever triggers
> > on s390, because most of the Linux device driver code does not get build
> > there anyway.
>
> Please don't do that. An s390 allyesconfig still triggers 45 warnings and
> I'm currently not willing to "patch" working code just to get rid of these
> warnings which are most likely all false positives.
> That's the reason why we currently don't error out and only generate
> warnings.
Can't you just turn that option off then? Or are you worried about
allyesconfig builds?
The current state is confusing because on s390
CONFIG_DEBUG_STRICT_USER_COPY_CHECKS means that gcc will warn rather
than ignore the finding, while on all others, the same option turns
a warning into an error.
Test-building an allmodconfig on s390 showed these warnings only in
architecture independent code, and I agree that they are all false
positives.
Arnd
next prev parent reply other threads:[~2010-08-24 15:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 3:02 [PATCH] ARM: uaccess: Implement strict user copy checks Stephen Boyd
2010-08-10 22:46 ` Stephen Boyd
2010-08-10 22:55 ` Russell King - ARM Linux
2010-08-11 0:27 ` Stephen Boyd
2010-08-18 1:29 ` [PATCH v2] " Stephen Boyd
2010-08-18 12:28 ` Arnd Bergmann
2010-08-18 19:48 ` Stephen Boyd
2010-08-19 11:09 ` Arnd Bergmann
2010-08-24 15:06 ` Heiko Carstens
2010-08-24 15:26 ` Arnd Bergmann [this message]
2010-08-24 15:47 ` Heiko Carstens
2010-08-25 12:14 ` Arnd Bergmann
2010-08-25 12:54 ` Heiko Carstens
2010-08-25 13:55 ` Arnd Bergmann
2010-08-25 14:40 ` Heiko Carstens
2010-08-28 1:35 ` Stephen Boyd
2010-08-28 7:43 ` Heiko Carstens
2010-08-28 9:56 ` Arnd Bergmann
2010-09-04 4:49 ` Stephen Boyd
2010-09-14 3:07 ` Stephen Boyd
2010-09-14 8:25 ` Heiko Carstens
2010-09-14 13:10 ` Arnd Bergmann
2010-09-14 14:18 ` Heiko Carstens
2010-08-19 2:28 ` [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd
2010-08-19 4:38 ` Arjan van de Ven
2010-08-19 4:47 ` Stephen Rothwell
2010-08-19 11:04 ` Arnd Bergmann
2010-08-11 3:04 ` [PATCH] ARM: uaccess: Implement strict user copy checks Arnd Bergmann
2010-08-11 18:46 ` Stephen Boyd
2010-08-12 15:00 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008241726.08797.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sboyd@codeaurora.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox