Re: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs

Peter Zijlstra
2010-08-19T17:53:55Z

On Thu, 2010-08-19 at 21:43 +0400, Cyrill Gorcunov wrote:
> > @@ -673,7 +673,7 @@ static int p4_pmu_handle_irq(struct pt_r
> > if (!overflow && (val & (1ULL << (x86_pmu.cntval_bits
> - 1))))
> > continue;
> >
> > - handled += overflow;
> > + handled += !!overflow;
>
> No need to !! here, overflowed returns [0;1] though a small nit
> and could be updated later :)

done.