From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933078Ab0HXW7l (ORCPT ); Tue, 24 Aug 2010 18:59:41 -0400 Received: from kroah.org ([198.145.64.141]:40538 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932933Ab0HXW72 (ORCPT ); Tue, 24 Aug 2010 18:59:28 -0400 X-Mailbox-Line: From gregkh@clark.site Tue Aug 24 15:42:17 2010 Message-Id: <20100824224217.641602408@clark.site> User-Agent: quilt/0.48-11.2 Date: Tue, 24 Aug 2010 15:42:27 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Dan Carpenter , "David S. Miller" , Tilman Schmidt Subject: [65/91] isdn: gigaset: add missing unlock In-Reply-To: <20100824224617.GA5440@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.34-stable review patch. If anyone has any objections, please let us know. ------------------ From: Dan Carpenter commit 7e27a0aeb98d53539bdc38384eee899d6db62617 upstream. We should unlock here. This is the only place where we return from the function with the lock held. The caller isn't expecting it. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Tilman Schmidt Signed-off-by: Greg Kroah-Hartman --- drivers/isdn/gigaset/capi.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/isdn/gigaset/capi.c +++ b/drivers/isdn/gigaset/capi.c @@ -1055,6 +1055,7 @@ static inline void remove_appl_from_chan do { if (bcap->bcnext == ap) { bcap->bcnext = bcap->bcnext->bcnext; + spin_unlock_irqrestore(&bcs->aplock, flags); return; } bcap = bcap->bcnext;