From: Andrew Morton <akpm@linux-foundation.org>
To: Huang Shijie <shijie8@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH] avoiding the same resource to be inserted
Date: Tue, 24 Aug 2010 23:41:32 -0700 [thread overview]
Message-ID: <20100824234132.a0f1cec3.akpm@linux-foundation.org> (raw)
In-Reply-To: <AANLkTikSPB+8R4E7rsoVS2GN9ysROAPzKsLHqgMyP_yM@mail.gmail.com>
On Wed, 25 Aug 2010 13:03:55 +0800 Huang Shijie <shijie8@gmail.com> wrote:
> On Wed, Aug 25, 2010 at 7:46 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>
> I think WARN_ON() is not power enough. If the CONFIG_BUG is not
> defined, the warning message may not be printed. So I think using a
> directly printk() here is better.
No, WARN_ON() is good. It gives us a backtrace and identifies the
buggy code. Only maniacs turn off CONFIG_BUG.
next prev parent reply other threads:[~2010-08-25 6:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 15:55 [PATCH] avoiding the same resource to be inserted Huang Shijie
2010-08-24 23:46 ` Andrew Morton
2010-08-25 4:31 ` Huang Shijie
2010-08-25 15:17 ` Bjorn Helgaas
2010-08-25 5:03 ` Huang Shijie
2010-08-25 6:41 ` Andrew Morton [this message]
2010-08-25 7:01 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824234132.a0f1cec3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox