From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: pxa-ssp: fix a memory leak in pxa_ssp_remove()
Date: Wed, 25 Aug 2010 14:22:12 +0100 [thread overview]
Message-ID: <20100825132212.GB1102@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1282726751.5051.4.camel@mola>
On Wed, Aug 25, 2010 at 04:59:11PM +0800, Axel Lin wrote:
> The "priv" allocated in pxa_ssp_probe() should be kfreed in pxa_ssp_remove().
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
This doesn't apply against current ASoC. I fixed this up by hand since
the error was so trivial but in future could you please make sure you
generate your code against the latest version of ASoC? This will be in
-next at any given time, or for the individual tree you want the latest
for-2.6.nn branch of:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
next prev parent reply other threads:[~2010-08-25 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 8:59 [PATCH] ASoC: pxa-ssp: fix a memory leak in pxa_ssp_remove() Axel Lin
2010-08-25 9:53 ` Liam Girdwood
2010-08-25 13:22 ` Mark Brown [this message]
2010-08-26 6:10 ` Axel Lin
2010-08-26 8:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825132212.GB1102@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox