* [PATCH] NOMMU: Stub out vm_get_page_prot() if there's no MMU
@ 2010-08-24 22:22 David Howells
2010-08-25 14:15 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 4+ messages in thread
From: David Howells @ 2010-08-24 22:22 UTC (permalink / raw)
To: vapier
Cc: linux-kernel, uclinux-dev, konrad.wilk, dgdegra, hugh, airlied,
davej, David Howells
Stub out vm_get_page_prot() if there's no MMU.
This was added by commit:
commit 804af2cf6e7af31d2e664b54e657dddd9b531dbd
Author: Hugh Dickins <hugh@veritas.com>
Date: Wed Jul 26 21:39:49 2006 +0100
Subject: [AGPGART] remove private page protection map
and is used in commit:
commit c07fbfd17e614a76b194f371c5331e21e6cffb54
Author: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Date: Tue Aug 10 18:02:45 2010 -0700
Subject: fbmem: VM_IO set, but not propagated
in the fbmem video driver, but the function doesn't exist on NOMMU, resulting
in an undefined symbol at link time.
Signed-off-by: David Howells <dhowells@redhat.com>
---
include/linux/mm.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 709f672..6b258c5 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1357,7 +1357,15 @@ static inline unsigned long vma_pages(struct vm_area_struct *vma)
return (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
}
+#ifdef CONFIG_MMU
pgprot_t vm_get_page_prot(unsigned long vm_flags);
+#else
+static inline pgprot_t vm_get_page_prot(unsigned long vm_flags)
+{
+ return __pgprot(0);
+}
+#endif
+
struct vm_area_struct *find_extend_vma(struct mm_struct *, unsigned long addr);
int remap_pfn_range(struct vm_area_struct *, unsigned long addr,
unsigned long pfn, unsigned long size, pgprot_t);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] NOMMU: Stub out vm_get_page_prot() if there's no MMU
2010-08-24 22:22 [PATCH] NOMMU: Stub out vm_get_page_prot() if there's no MMU David Howells
@ 2010-08-25 14:15 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2010-08-25 14:15 UTC (permalink / raw)
To: David Howells
Cc: vapier, linux-kernel, uclinux-dev, dgdegra, hugh, airlied, davej
On Tue, Aug 24, 2010 at 11:22:38PM +0100, David Howells wrote:
> Stub out vm_get_page_prot() if there's no MMU.
>
> This was added by commit:
>
> commit 804af2cf6e7af31d2e664b54e657dddd9b531dbd
> Author: Hugh Dickins <hugh@veritas.com>
> Date: Wed Jul 26 21:39:49 2006 +0100
> Subject: [AGPGART] remove private page protection map
>
> and is used in commit:
>
> commit c07fbfd17e614a76b194f371c5331e21e6cffb54
> Author: Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Date: Tue Aug 10 18:02:45 2010 -0700
> Subject: fbmem: VM_IO set, but not propagated
>
> in the fbmem video driver, but the function doesn't exist on NOMMU, resulting
> in an undefined symbol at link time.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thanks for coming up with the patch!
> ---
>
> include/linux/mm.h | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 709f672..6b258c5 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1357,7 +1357,15 @@ static inline unsigned long vma_pages(struct vm_area_struct *vma)
> return (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> }
>
> +#ifdef CONFIG_MMU
> pgprot_t vm_get_page_prot(unsigned long vm_flags);
> +#else
> +static inline pgprot_t vm_get_page_prot(unsigned long vm_flags)
> +{
> + return __pgprot(0);
> +}
> +#endif
> +
> struct vm_area_struct *find_extend_vma(struct mm_struct *, unsigned long addr);
> int remap_pfn_range(struct vm_area_struct *, unsigned long addr,
> unsigned long pfn, unsigned long size, pgprot_t);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] NOMMU: Stub out vm_get_page_prot() if there's no MMU
@ 2010-08-26 15:00 David Howells
0 siblings, 0 replies; 4+ messages in thread
From: David Howells @ 2010-08-26 15:00 UTC (permalink / raw)
To: torvalds, akpm
Cc: vapier.adi, konrad.wilk, gavinl, uclinux-dev, linux-kernel,
David Howells
Stub out vm_get_page_prot() if there's no MMU.
This was added by commit:
commit 804af2cf6e7af31d2e664b54e657dddd9b531dbd
Author: Hugh Dickins <hugh@veritas.com>
Date: Wed Jul 26 21:39:49 2006 +0100
Subject: [AGPGART] remove private page protection map
and is used in commit:
commit c07fbfd17e614a76b194f371c5331e21e6cffb54
Author: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Date: Tue Aug 10 18:02:45 2010 -0700
Subject: fbmem: VM_IO set, but not propagated
in the fbmem video driver, but the function doesn't exist on NOMMU, resulting
in an undefined symbol at link time.
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
include/linux/mm.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 831c693..e6b1210 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1363,7 +1363,15 @@ static inline unsigned long vma_pages(struct vm_area_struct *vma)
return (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
}
+#ifdef CONFIG_MMU
pgprot_t vm_get_page_prot(unsigned long vm_flags);
+#else
+static inline pgprot_t vm_get_page_prot(unsigned long vm_flags)
+{
+ return __pgprot(0);
+}
+#endif
+
struct vm_area_struct *find_extend_vma(struct mm_struct *, unsigned long addr);
int remap_pfn_range(struct vm_area_struct *, unsigned long addr,
unsigned long pfn, unsigned long size, pgprot_t);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] NOMMU: Stub out vm_get_page_prot() if there's no MMU
@ 2010-08-24 22:21 David Howells
0 siblings, 0 replies; 4+ messages in thread
From: David Howells @ 2010-08-24 22:21 UTC (permalink / raw)
To: vapier; +Cc: linux-kernel, uclinux-dev, David Howells
Stub out vm_get_page_prot() if there's no MMU.
This was added by commit:
commit 804af2cf6e7af31d2e664b54e657dddd9b531dbd
Author: Hugh Dickins <hugh@veritas.com>
Date: Wed Jul 26 21:39:49 2006 +0100
Subject: [AGPGART] remove private page protection map
and is used in commit:
commit c07fbfd17e614a76b194f371c5331e21e6cffb54
Author: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Date: Tue Aug 10 18:02:45 2010 -0700
Subject: fbmem: VM_IO set, but not propagated
in the fbmem video driver, but the function doesn't exist on NOMMU, resulting
in an undefined symbol at link time.
Signed-off-by: David Howells <dhowells@redhat.com>
---
include/linux/mm.h | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 709f672..6b258c5 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1357,7 +1357,15 @@ static inline unsigned long vma_pages(struct vm_area_struct *vma)
return (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
}
+#ifdef CONFIG_MMU
pgprot_t vm_get_page_prot(unsigned long vm_flags);
+#else
+static inline pgprot_t vm_get_page_prot(unsigned long vm_flags)
+{
+ return __pgprot(0);
+}
+#endif
+
struct vm_area_struct *find_extend_vma(struct mm_struct *, unsigned long addr);
int remap_pfn_range(struct vm_area_struct *, unsigned long addr,
unsigned long pfn, unsigned long size, pgprot_t);
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-26 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-24 22:22 [PATCH] NOMMU: Stub out vm_get_page_prot() if there's no MMU David Howells
2010-08-25 14:15 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2010-08-26 15:00 David Howells
2010-08-24 22:21 David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox