From: Arnd Bergmann <arnd@arndb.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH v2] ARM: uaccess: Implement strict user copy checks
Date: Wed, 25 Aug 2010 15:55:53 +0200 [thread overview]
Message-ID: <201008251555.53653.arnd@arndb.de> (raw)
In-Reply-To: <20100825125451.GH2153@osiris.boeblingen.de.ibm.com>
On Wednesday 25 August 2010, Heiko Carstens wrote:
>
> On Wed, Aug 25, 2010 at 02:14:16PM +0200, Arnd Bergmann wrote:
> > > Then maybe add a "choice" Kconfig option in a way that both allyesconfig
> > > as well as allnoconfig will build?
> >
> > I think it would be easier to remove the config option entirely on s390
> > and just always warn. As I said earlier in this thread, I generally
> > don't think this particular warning is more important than a lot of
> > the other ones that we don't turn into errors.
>
> I disagree: a default kernel build should compile without the noise of
> tens of false positive warnings.
> Nobody would look at new warnings and fix possible bugs.
> That's why I want to have an option to turn the warnings off (default).
>
> Or are you volunteering to "fix" all the false positives? :)
If you don't want to see the warnings, then just remove the strict checks.
We already concluded that there is little value in them on s390 since it only
shows false postives.
Maybe the easiest way would be to rename the option on s390 and move all
the other ones into a common place.
Arnd
next prev parent reply other threads:[~2010-08-25 13:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 3:02 [PATCH] ARM: uaccess: Implement strict user copy checks Stephen Boyd
2010-08-10 22:46 ` Stephen Boyd
2010-08-10 22:55 ` Russell King - ARM Linux
2010-08-11 0:27 ` Stephen Boyd
2010-08-18 1:29 ` [PATCH v2] " Stephen Boyd
2010-08-18 12:28 ` Arnd Bergmann
2010-08-18 19:48 ` Stephen Boyd
2010-08-19 11:09 ` Arnd Bergmann
2010-08-24 15:06 ` Heiko Carstens
2010-08-24 15:26 ` Arnd Bergmann
2010-08-24 15:47 ` Heiko Carstens
2010-08-25 12:14 ` Arnd Bergmann
2010-08-25 12:54 ` Heiko Carstens
2010-08-25 13:55 ` Arnd Bergmann [this message]
2010-08-25 14:40 ` Heiko Carstens
2010-08-28 1:35 ` Stephen Boyd
2010-08-28 7:43 ` Heiko Carstens
2010-08-28 9:56 ` Arnd Bergmann
2010-09-04 4:49 ` Stephen Boyd
2010-09-14 3:07 ` Stephen Boyd
2010-09-14 8:25 ` Heiko Carstens
2010-09-14 13:10 ` Arnd Bergmann
2010-09-14 14:18 ` Heiko Carstens
2010-08-19 2:28 ` [PATCHv2 2/1] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd
2010-08-19 4:38 ` Arjan van de Ven
2010-08-19 4:47 ` Stephen Rothwell
2010-08-19 11:04 ` Arnd Bergmann
2010-08-11 3:04 ` [PATCH] ARM: uaccess: Implement strict user copy checks Arnd Bergmann
2010-08-11 18:46 ` Stephen Boyd
2010-08-12 15:00 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008251555.53653.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sboyd@codeaurora.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox