Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

Stephen Hemminger
2010-08-26T15:47:50Z

On Thu, 26 Aug 2010 18:56:55 +0900
Masayuki Ohtake <masa-korg@dsn.okisemi.com> wrote:

> +/**
> + * pch_gbe_alloc_queues - Allocate memory for all rings
> + * @adapter: Board private structure to initialize
> + * Returns
> + * 0: Successfully
> + * Negative value: Failed
> + */
> +static int pch_gbe_alloc_queues(struct pch_gbe_adapter *adapter)
> +{
> + int size;
> +
> + PCH_GBE_DEBUG("%s\n", __func__);
> +
> +
> + size = (int)sizeof(struct pch_gbe_tx_ring);
> + adapter->tx_ring = kmalloc(size, GFP_KERNEL);
> + if (!adapter->tx_ring)
> + return -ENOMEM;
> + memset(adapter->tx_ring, 0, size);
> +
> + size = (int)sizeof(struct pch_gbe_rx_ring);
> + adapter->rx_ring = kmalloc(size, GFP_KERNEL);
> + if (!adapter->rx_ring) {
> + kfree(adapter->tx_ring);
> + return -ENOMEM;
> + }
> + memset(adapter->rx_ring, 0, size);
> +
> + size = (int)sizeof(struct net_device);
> + adapter->polling_netdev = kmalloc(size, GFP_KERNEL);
> + if (!adapter->polling_netdev) {
> + kfree(adapter->tx_ring);
> + kfree(adapter->rx_ring);
> + return -ENOMEM;

This is not allowed, you can not just allocate up a network
device structure out of kmalloc space. Not sure what you are doing
with the polling_netdev? Is it left over from when net_device
and NAPI were more closely bound?

--