Re: [PATCH] drivers/net/pch_gbe: Cleanup stats use

Stephen Hemminger
2010-09-01T01:33:36Z

On Tue, 31 Aug 2010 11:38:35 -0700
Joe Perches <joe@perches.com> wrote:

> struct pch_gbe_stats {
> - signed char stat_string[ETH_GSTRING_LEN];
> - int sizeof_stat;
> - int stat_offset;
> + signed char string[ETH_GSTRING_LEN];
> + size_t size;
> + size_t offset;
> };

Is this driver really using 'signed char' here?
Should just be 'char' for a simple string.