public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: tj@kernel.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, fweisbec@gmail.com,
	rostedt@goodmis.org
Subject: Re: [PATCH] workqueue: Add basic tracepoints to track workqueue execution
Date: Thu, 26 Aug 2010 10:35:43 -0400	[thread overview]
Message-ID: <20100826143542.GA2947@redhat.com> (raw)
In-Reply-To: <20100821131402.577c4d75@infradead.org>

On Sat, Aug 21, 2010 at 01:14:02PM -0700, Arjan van de Ven wrote:
> With the introduction of the new unified work queue thread pools,
> we lost one feature: It's no longer possible to know which worker
> is causing the CPU to wake out of idle. The result is that PowerTOP
> now reports a lot of "kworker/a:b" instead of more readable results.
> 
> This patch adds a pair of tracepoints to the new workqueue code,
> similar in style to the timer/hrtimer tracepoints.
> 

Hi,

it might also be nice to add a workqueue chapter to the traceopint docbook.
Since you've already included kernel-doc style comments, the below is all that
we need.

current book is at: http://www.kernel.org/doc/htmldocs/tracepoint/

thanks,

-Jason


Add a workqueue chapter to the tracepoint docbook

Signed-off-by: Jason Baron <jbaron@redhat.com>

---
 Documentation/DocBook/tracepoint.tmpl |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/Documentation/DocBook/tracepoint.tmpl b/Documentation/DocBook/tracepoint.tmpl
index e8473ea..b57a9ed 100644
--- a/Documentation/DocBook/tracepoint.tmpl
+++ b/Documentation/DocBook/tracepoint.tmpl
@@ -104,4 +104,9 @@
    <title>Block IO</title>
 !Iinclude/trace/events/block.h
   </chapter>
+
+  <chapter id="workqueue">
+   <title>Workqueue</title>
+!Iinclude/trace/events/workqueue.h
+  </chapter>
 </book>
-- 
1.6.0.6


  parent reply	other threads:[~2010-08-26 14:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-21 20:14 [PATCH] workqueue: Add basic tracepoints to track workqueue execution Arjan van de Ven
2010-08-22  3:21 ` Frederic Weisbecker
2010-08-22  4:01 ` Frederic Weisbecker
2010-08-23  9:46   ` Tejun Heo
2010-08-27 13:14     ` Frederic Weisbecker
2010-08-26 14:35 ` Jason Baron [this message]
2010-08-27 10:29   ` [PATCH] workqueue: Add a workqueue chapter to the tracepoint docbook Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100826143542.GA2947@redhat.com \
    --to=jbaron@redhat.com \
    --cc=arjan@infradead.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox