From: Don Zickus <dzickus@redhat.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Robert Richter <robert.richter@amd.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Lin Ming <ming.m.lin@intel.com>,
"fweisbec@gmail.com" <fweisbec@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Huang, Ying" <ying.huang@intel.com>,
Yinghai Lu <yinghai@kernel.org>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs
Date: Thu, 26 Aug 2010 12:40:31 -0400 [thread overview]
Message-ID: <20100826164031.GO4879@redhat.com> (raw)
In-Reply-To: <20100826153404.GA6306@lenovo>
On Thu, Aug 26, 2010 at 07:34:04PM +0400, Cyrill Gorcunov wrote:
> > I'll keep looking for the race condition to better fix it.
> >
> > Cheers,
> > Don
> >
>
> Sounds promising, mind to post new inter-diff? Ie what you have
> changed from Robert's patch.
It was really in Peter's patch, just a stupid hack for now.
Cheers,
Don
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index 4539b4b..9e65a7b 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -777,7 +777,9 @@ again:
done:
intel_pmu_enable_all(0);
- return handled;
+ if (!handled)
+ return handled;
+ return ++handled;
}
static struct event_constraint *
next prev parent reply other threads:[~2010-08-26 16:41 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 15:05 [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs Don Zickus
2010-08-20 15:25 ` Ingo Molnar
2010-08-23 8:53 ` Ingo Molnar
2010-08-24 16:22 ` Cyrill Gorcunov
2010-08-24 17:09 ` Robert Richter
2010-08-24 17:20 ` Cyrill Gorcunov
2010-08-24 17:21 ` Cyrill Gorcunov
2010-08-24 17:15 ` Robert Richter
2010-08-24 17:28 ` Cyrill Gorcunov
2010-08-24 18:46 ` Don Zickus
2010-08-24 18:54 ` Cyrill Gorcunov
2010-08-24 19:52 ` Cyrill Gorcunov
2010-08-24 20:27 ` Don Zickus
2010-08-24 20:40 ` Cyrill Gorcunov
2010-08-25 23:52 ` Frederic Weisbecker
2010-08-26 9:11 ` Cyrill Gorcunov
2010-08-25 10:20 ` Robert Richter
2010-08-26 21:14 ` Don Zickus
2010-08-27 7:51 ` Robert Richter
2010-08-27 13:39 ` Don Zickus
2010-08-27 8:10 ` Robert Richter
2010-08-27 13:44 ` Don Zickus
2010-08-27 14:05 ` Robert Richter
2010-08-27 15:05 ` Don Zickus
2010-08-27 15:48 ` Robert Richter
2010-08-27 18:57 ` Don Zickus
2010-08-27 19:00 ` Yinghai Lu
2010-08-27 19:33 ` Robert Richter
2010-08-25 9:48 ` Robert Richter
2010-08-25 10:41 ` Ingo Molnar
2010-08-25 11:00 ` Ingo Molnar
2010-08-25 20:11 ` Don Zickus
2010-08-25 20:24 ` Cyrill Gorcunov
2010-08-25 21:20 ` Don Zickus
2010-08-25 21:36 ` Cyrill Gorcunov
2010-08-26 9:00 ` Robert Richter
2010-08-26 9:18 ` Cyrill Gorcunov
2010-08-26 14:31 ` Don Zickus
2010-08-26 15:22 ` Don Zickus
2010-08-26 15:34 ` Cyrill Gorcunov
2010-08-26 16:40 ` Don Zickus [this message]
2010-08-26 18:02 ` Cyrill Gorcunov
2010-08-27 7:57 ` Robert Richter
2010-08-27 8:11 ` Peter Zijlstra
2010-08-27 8:31 ` Robert Richter
2010-08-25 11:02 ` Robert Richter
2010-08-25 11:19 ` Ingo Molnar
2010-08-20 23:31 ` Don Zickus
-- strict thread matches above, loose matches on Subject: below --
2010-08-04 15:18 A question of perf NMI handler Cyrill Gorcunov
2010-08-04 15:50 ` Don Zickus
2010-08-04 16:10 ` Cyrill Gorcunov
2010-08-04 16:20 ` Don Zickus
2010-08-04 16:39 ` Cyrill Gorcunov
2010-08-04 18:48 ` Robert Richter
2010-08-04 19:26 ` Cyrill Gorcunov
2010-08-06 6:52 ` Robert Richter
2010-08-06 14:21 ` Don Zickus
2010-08-09 19:48 ` [PATCH] perf, x86: try to handle unknown nmis with running perfctrs Robert Richter
2010-08-17 15:22 ` [PATCH -v3] " Robert Richter
2010-08-17 16:17 ` Cyrill Gorcunov
2010-08-19 10:45 ` Peter Zijlstra
2010-08-19 12:39 ` Robert Richter
2010-08-19 14:12 ` Don Zickus
2010-08-19 14:27 ` Peter Zijlstra
2010-08-19 15:20 ` Don Zickus
2010-08-19 17:43 ` Cyrill Gorcunov
2010-08-19 17:53 ` Peter Zijlstra
2010-08-19 21:58 ` Don Zickus
2010-08-20 8:50 ` Peter Zijlstra
2010-08-20 1:50 ` Don Zickus
2010-08-20 8:16 ` Ingo Molnar
2010-08-20 10:04 ` Peter Zijlstra
2010-08-20 10:30 ` Cyrill Gorcunov
2010-08-20 12:39 ` Don Zickus
2010-08-20 13:27 ` Ingo Molnar
2010-08-20 13:51 ` Don Zickus
2010-08-20 14:17 ` Ingo Molnar
2010-08-20 20:45 ` Cyrill Gorcunov
2010-08-24 21:48 ` Don Zickus
2010-08-20 8:36 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100826164031.GO4879@redhat.com \
--to=dzickus@redhat.com \
--cc=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=ying.huang@intel.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).