[PATCH] hwmon: Add tempX_emergency to sysfs ABI

[PATCH] hwmon: Add tempX_emergency to sysfs ABI

[Guenter Roeck]

Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
---
tempX_emergency will be used by max6696. It can also be used for other chips
supporting three upper temperature limits.

 Documentation/hwmon/sysfs-interface |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
index ff45d1f..1ceb2b9 100644
--- a/Documentation/hwmon/sysfs-interface
+++ b/Documentation/hwmon/sysfs-interface
@@ -310,6 +310,12 @@ temp[1-*]_crit_hyst
 		from the critical value.
 		RW
 
+temp[1-*]_emergency
+		Temperature emergency value, typically greater than
+		corresponding temp_crit values.
+		Unit: millidegree Celsius
+		RW
+
 temp[1-*]_lcrit	Temperature critical min value, typically lower than
 		corresponding temp_min values.
 		Unit: millidegree Celsius
-- 
1.7.0.87.g0901d

Re: [lm-sensors] [PATCH] hwmon: Add tempX_emergency to sysfs ABI

[Henrique de Moraes Holschuh]

On Thu, 26 Aug 2010, Guenter Roeck wrote:
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> tempX_emergency will be used by max6696. It can also be used for other chips
> supporting three upper temperature limits.
> 
>  Documentation/hwmon/sysfs-interface |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index ff45d1f..1ceb2b9 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -310,6 +310,12 @@ temp[1-*]_crit_hyst
>  		from the critical value.
>  		RW
>  
> +temp[1-*]_emergency
> +		Temperature emergency value, typically greater than
> +		corresponding temp_crit values.
> +		Unit: millidegree Celsius
> +		RW
> +

If we have two-level alarms: critical, then emergency, it is best to have
that written down than to imply it by "typically greater than corresponding
temp_crit"...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [lm-sensors] [PATCH] hwmon: Add tempX_emergency to sysfs ABI

[Guenter Roeck]

On Thu, Aug 26, 2010 at 12:10:23PM -0400, Henrique de Moraes Holschuh wrote:
> On Thu, 26 Aug 2010, Guenter Roeck wrote:
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > ---
> > tempX_emergency will be used by max6696. It can also be used for other chips
> > supporting three upper temperature limits.
> > 
> >  Documentation/hwmon/sysfs-interface |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> > index ff45d1f..1ceb2b9 100644
> > --- a/Documentation/hwmon/sysfs-interface
> > +++ b/Documentation/hwmon/sysfs-interface
> > @@ -310,6 +310,12 @@ temp[1-*]_crit_hyst
> >  		from the critical value.
> >  		RW
> >  
> > +temp[1-*]_emergency
> > +		Temperature emergency value, typically greater than
> > +		corresponding temp_crit values.
> > +		Unit: millidegree Celsius
> > +		RW
> > +
> 
> If we have two-level alarms: critical, then emergency, it is best to have
> that written down than to imply it by "typically greater than corresponding
> temp_crit"...
> 
Do you have a better wording in mind ?

Guenter

Re: [lm-sensors] [PATCH] hwmon: Add tempX_emergency to sysfs ABI

[Guenter Roeck]

On Thu, Aug 26, 2010 at 12:10:23PM -0400, Henrique de Moraes Holschuh wrote:
> On Thu, 26 Aug 2010, Guenter Roeck wrote:
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > ---
> > tempX_emergency will be used by max6696. It can also be used for other chips
> > supporting three upper temperature limits.
> > 
> >  Documentation/hwmon/sysfs-interface |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> > index ff45d1f..1ceb2b9 100644
> > --- a/Documentation/hwmon/sysfs-interface
> > +++ b/Documentation/hwmon/sysfs-interface
> > @@ -310,6 +310,12 @@ temp[1-*]_crit_hyst
> >  		from the critical value.
> >  		RW
> >  
> > +temp[1-*]_emergency
> > +		Temperature emergency value, typically greater than
> > +		corresponding temp_crit values.
> > +		Unit: millidegree Celsius
> > +		RW
> > +
> 
> If we have two-level alarms: critical, then emergency, it is best to have
> that written down than to imply it by "typically greater than corresponding
> temp_crit"...
> 
How about:
        Temperature emergency max value, for chips supporting more than
        two upper temperature limits. Must be equal or greater than
        corresponding temp_crit values.
        Unit: millidegree Celsius
        RW

Guenter

Re: [lm-sensors] [PATCH] hwmon: Add tempX_emergency to sysfs ABI

[Henrique de Moraes Holschuh]

On Thu, 26 Aug 2010, Guenter Roeck wrote:
> > > +temp[1-*]_emergency
> > > +		Temperature emergency value, typically greater than
> > > +		corresponding temp_crit values.
> > > +		Unit: millidegree Celsius
> > > +		RW
> > > +
> > 
> > If we have two-level alarms: critical, then emergency, it is best to have
> > that written down than to imply it by "typically greater than corresponding
> > temp_crit"...
> > 
> How about:
>         Temperature emergency max value, for chips supporting more than
>         two upper temperature limits. Must be equal or greater than
>         corresponding temp_crit values.
>         Unit: millidegree Celsius
>         RW

Much better, thank you.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh