* [PATCH] regulator: set max8998->dev to &pdev->dev.
@ 2010-08-27 8:37 Axel Lin
2010-08-27 9:30 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2010-08-27 8:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown, Kyungmin Park, Marek Szyprowski
max8998->dev is NULL in current implementation, set it to &pdev->dev.
regulator_register() still return success if max8998->dev is NULL,
but rdev->dev.parent will be set to NULL which is incorrect.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/max8998.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/max8998.c b/drivers/regulator/max8998.c
index 8b9bfdf..a1baf1f 100644
--- a/drivers/regulator/max8998.c
+++ b/drivers/regulator/max8998.c
@@ -557,6 +557,7 @@ static __devinit int max8998_pmic_probe(struct platform_device *pdev)
}
rdev = max8998->rdev;
+ max8998->dev = &pdev->dev;
max8998->iodev = iodev;
max8998->num_regulators = pdata->num_regulators;
platform_set_drvdata(pdev, max8998);
--
1.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: set max8998->dev to &pdev->dev.
2010-08-27 8:37 [PATCH] regulator: set max8998->dev to &pdev->dev Axel Lin
@ 2010-08-27 9:30 ` Mark Brown
2010-08-27 13:04 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2010-08-27 9:30 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Kyungmin Park, Marek Szyprowski
On Fri, Aug 27, 2010 at 04:37:34PM +0800, Axel Lin wrote:
> max8998->dev is NULL in current implementation, set it to &pdev->dev.
>
> regulator_register() still return success if max8998->dev is NULL,
> but rdev->dev.parent will be set to NULL which is incorrect.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: set max8998->dev to &pdev->dev.
2010-08-27 9:30 ` Mark Brown
@ 2010-08-27 13:04 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-08-27 13:04 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, Kyungmin Park, Marek Szyprowski
On Fri, 2010-08-27 at 10:30 +0100, Mark Brown wrote:
> On Fri, Aug 27, 2010 at 04:37:34PM +0800, Axel Lin wrote:
> > max8998->dev is NULL in current implementation, set it to &pdev->dev.
> >
> > regulator_register() still return success if max8998->dev is NULL,
> > but rdev->dev.parent will be set to NULL which is incorrect.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> --
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-27 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-27 8:37 [PATCH] regulator: set max8998->dev to &pdev->dev Axel Lin
2010-08-27 9:30 ` Mark Brown
2010-08-27 13:04 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox