From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Moffett, Kyle D" <Kyle.D.Moffett@boeing.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kyle Moffett <kyle@moffetthome.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] sky2: Add unidirectional fiber link support
Date: Fri, 27 Aug 2010 14:22:17 -0700 [thread overview]
Message-ID: <20100827142217.5fccc098@nehalam> (raw)
In-Reply-To: <81DAD951-0909-4D3A-8451-AEE3F9B07054@boeing.com>
On Fri, 27 Aug 2010 15:51:58 -0500
"Moffett, Kyle D" <Kyle.D.Moffett@boeing.com> wrote:
> On Aug 27, 2010, at 16:38, Stephen Hemminger wrote:
> > On Fri, 27 Aug 2010 15:42:18 -0400 Kyle Moffett <Kyle.D.Moffett@boeing.com> wrote:
> >> + /*
> >> + * Once interrupts are reenabled, reset the PHY again to make sure
> >> + * that we didn't miss a link-up interrupt. This is especially
> >> + * likely to occur if we're in fiber-txonly mode, as a link-up
> >> + * interrupt is generated almost immediately after we finish
> >> + * programming the PHY.
> >> + */
> >> + sky2_phy_reinit(sky2);
> >
> > Won't this cause a renegotiation causing up to 2 second delay?
>
> Well, I suppose that's possible, but we've only just reset and enabled the PHY moments before, so I don't see where you could get an *extra* 2-second delay. On the other hand, I suppose it would be much nicer if there was an easy way to fake an extra interrupt there instead of reinitializing the whole PHY. I'm not all that comfortable with my understanding of the interrupt logic in the sky2 driver, so I figured I would just reuse all the necessary locking from sky2_phy_reinit().
>
> Do you have any comments or criticisms of the particular "duplex" method of configuring the unidirectional link support?
No that is fine, but the FIB doesn't really understand RX only links
so I expect users will do stupid things.
next prev parent reply other threads:[~2010-08-27 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 19:42 [RFC] Support for unidirectional ethernet links Kyle Moffett
2010-08-27 19:42 ` [PATCH 1/2] ethtool.h: Add #defines for unidirectional ethernet duplex Kyle Moffett
2010-08-28 23:03 ` David Miller
2010-08-29 7:34 ` Kyle Moffett
2010-08-27 19:42 ` [PATCH 2/2] sky2: Add unidirectional fiber link support Kyle Moffett
2010-08-27 20:38 ` Stephen Hemminger
2010-08-27 20:51 ` Moffett, Kyle D
2010-08-27 21:22 ` Stephen Hemminger [this message]
2010-08-28 5:35 ` Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827142217.5fccc098@nehalam \
--to=shemminger@linux-foundation.org \
--cc=Kyle.D.Moffett@boeing.com \
--cc=kyle@moffetthome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox