Re: [PATCH V2 3/4] oprofile: Abstract the perf-events backend

Robert Richter
2010-08-27T13:02:32Z

On 26.08.10 15:09:18, Matt Fleming wrote:
> Move the perf-events backend from arch/arm/oprofile into
> drivers/oprofile so that the code can be shared between architectures.
>
> This allows each architecture to maintain only a single copy of the
> PMU accessor functions instead of one for both perf and OProfile. It
> also becomes possible for other architectures to delete much of their
> OProfile code in favour of the common code now available in
> drivers/oprofile/oprofile_perf.c.
>
> Signed-off-by: Matt Fleming <matt@console-pimps.org>
> ---
> arch/arm/oprofile/Makefile | 4 +
> arch/arm/oprofile/common.c | 215 +++-----------------------------------
> drivers/oprofile/oprofile_perf.c | 209 ++++++++++++++++++++++++++++++++++++
> include/linux/oprofile.h | 12 ++
> 4 files changed, 242 insertions(+), 198 deletions(-)
> create mode 100644 drivers/oprofile/oprofile_perf.c

Could we split this patch in 2 for better review? One that only moves
the code and a 2nd that changes it.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center