From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [PATCH] perf: Remove newline character from perror() argument
Date: Sat, 28 Aug 2010 12:52:51 -0300 [thread overview]
Message-ID: <20100828155251.GP2973@ghostprotocols.net> (raw)
In-Reply-To: <89e77b54659bc3798b23a5596c2debb7f6f4cf27.1283010281.git.matt@console-pimps.org>
Em Sat, Aug 28, 2010 at 04:46:19PM +0100, Matt Fleming escreveu:
> If we include a newline character in the string argument to perror()
> then the output will be split across two lines like so,
>
> Unable to read perf file descriptor
> : No space left on device
>
> Deleting the newline character prints a much more readable error,
>
> Unable to read perf file descriptor: No space left on device
Thanks, applying.
- Arnaldo
next prev parent reply other threads:[~2010-08-28 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 15:46 [PATCH] perf: Remove newline character from perror() argument Matt Fleming
2010-08-28 15:52 ` Arnaldo Carvalho de Melo [this message]
2010-10-26 14:34 ` Matt Fleming
2010-10-26 14:52 ` Arnaldo Carvalho de Melo
2010-10-27 11:01 ` [tip:perf/urgent] perf record: " tip-bot for Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100828155251.GP2973@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox