Re: [PATCH 2/4] sparc: break out some prom device-tree building code out into drivers/of

Andres Salomon
2010-06-29T15:03:37Z

On Tue, 29 Jun 2010 00:50:08 -0700
Grant Likely <grant.likely@secretlab.ca> wrote:

> On Mon, Jun 28, 2010 at 7:00 PM, Andres Salomon <dilinger@queued.net> wrote:
> >
> > Stick code into drivers/of/pdt.c (Prom Device Tree) that other
> > architectures with OpenFirmware resident in memory can make use of.
> >
> > Signed-off-by: Andres Salomon <dilinger@queued.net>
>
> Hi Andres,
>
> The patch itself looks fine, but there are currently two methods for
> extracting the device tree from open firmware; one in arch/powerpc
> using the flattened format, and one in arch/sparc. I don't want to
> end up maintaining both methods in drivers/of, and there has also some
> discussions on moving the powerpc version into common code. I've been
> thinking about using the powerpc approach to support ARM platforms
> using both the flat tree and real OFW.
>
> Ben, what say you? Before I do anything I'd like to have your opinion.
>

So you're saying that you want ARM (and sparc, and OLPC) to generate a
flat tree by calling into OFW? Sparc and OLPC have very similar
mechanisms for getting device tree info from OFW, so it makes sense to
share code between them.