From: Sam Ravnborg <sam@ravnborg.org>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Phillip Lougher <phillip@lougher.demon.co.uk>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] init: use kern_sys_* wrappers instead of syscall
Date: Mon, 30 Aug 2010 21:10:21 +0200 [thread overview]
Message-ID: <20100830191021.GC12921@merkur.ravnborg.org> (raw)
In-Reply-To: <1283189270-7274-3-git-send-email-namhyung@gmail.com>
On Tue, Aug 31, 2010 at 02:27:50AM +0900, Namhyung Kim wrote:
> replace direct syscall invocations to its wrapper functions defined
> in init/sys-wrapper.h
Please explain again that this fixes sparse warnings.
And list the sparse warnings that gets fixed - or at least some
abbrevated sample of tham.
Comment about inverse christmas tree apply to this patch in a few spots.
The patch does not apply to -linus.
In realise this is because it is made on top of another patch of yours
that is already in -mm.
But it would be better to say that this first patch should be replaced
by this second patch that does the same and more.
Sam
prev parent reply other threads:[~2010-08-30 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 17:27 [PATCH v3 0/2] init cleanups Namhyung Kim
2010-08-30 17:27 ` [PATCH v3 1/2] init: add sys-wrapper.h Namhyung Kim
2010-08-30 19:03 ` Sam Ravnborg
2010-08-31 14:16 ` Namhyung Kim
2010-08-31 14:30 ` Sam Ravnborg
2010-08-31 14:34 ` Namhyung Kim
2010-08-30 17:27 ` [PATCH v3 2/2] init: use kern_sys_* wrappers instead of syscall Namhyung Kim
2010-08-30 19:10 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100830191021.GC12921@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=phillip@lougher.demon.co.uk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox