Re: [PATCH] sunrpc: prompt for RPCSEC_GSS_KRB5 even if NFS_V4 is enabled

Trond Myklebust
2010-09-27T11:39:37Z

On Mon, 2010-09-27 at 12:41 +0200, Uwe Kleine-König wrote:
> NFS_V4 works fine without RPCSEC_GSS_KRB5 (even without CRYPTO).
> This dependency was introduced in
>
> df486a2 (NFS: Fix the selection of security flavours in Kconfig)
>
> to fix a build failure as RPCSEC_GSS_KRB5 was thought to be needed for
> NFS_V4. The fix didn't work completely as NFS_V4 didn't enforce CRYPTO
> and so the select on RPCSEC_GSS_KRB5 didn't work in all situations (e.g.
> arm/mx1_defconfig).
>
> This was rectified by
>
> 827e345 (SUNRPC: Fix the NFSv4 and RPCSEC_GSS Kconfig dependencies)
>
> but the magic for RPCSEC_GSS_KRB5 introduced by df486a2 wasn't reverted.
>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> after Trond sent me the patch that later ended in 827e345702 I suggested
> to fold the patch below into it[1], but without reaction and success as I
> noticed just now. :-(
>
> Best regards
> Uwe

That's because you completely fail to justify why should we change the
behaviour to suddenly make RPCSEC_GSS_KRB5 optional for NFSv4. That has
never been the case before.

Trond