From: Florian Fainelli <florian@openwrt.org>
To: David Brownell <david-b@pacbell.net>
Cc: Willy Tarreau <w@1wt.eu>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Samuel Ortiz <sameo@linux.intel.com>,
Miguel Gaio <miguel.gaio@efixo.com>,
Juhos Gabor <juhosg@openwrt.org>,
dbrownell@users.sourceforge.net
Subject: Re: [PATCH v2] GPIO: add support for 74HC164 serial-in/parallel-out 8-bit shift register
Date: Tue, 31 Aug 2010 10:17:30 +0200 [thread overview]
Message-ID: <201008311017.30445.florian@openwrt.org> (raw)
In-Reply-To: <887649.75421.qm@web180316.mail.gq1.yahoo.com>
Hi David,
On Tuesday 31 August 2010 01:43:04 David Brownell wrote:
> generic to all
>
> > 74HC164 chips
>
> Not just HC-series logic, also HCT, AC, etc (as
> I noted previously).
>
> I'm glad you took NXP (one of the N vendors)
> out of the name, but I think you should also
> take the logic series out; "74x164 might be sufficiently generic.
Allright, I will respin with those changes. Note that I chose to prefix the
data structures with gen_ (for obvious C language reasons), I hope this is
fine.
>
>
> > pdata->gpio_pin_clk, err);
>
> I'm a bit puzzled why you don't just hook the
> chip up using standard SPI signals... ISTR they
> matched up directly to what the chip needs, so
> no GPIOs were needed for interface glue.
The board this driver is being used on had no SPI signals left I think, so it
was hooked up on separate GPIO lines (which cannot be muxed to the GPIO pad).
--
Florian
next prev parent reply other threads:[~2010-08-31 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 23:18 [PATCH] GPIO: add support for NXP 74HC164 GPIO expander David Brownell
2010-08-29 10:10 ` Willy Tarreau
2010-08-29 15:37 ` [PATCH v2] GPIO: add support for 74HC164 serial-in/parallel-out 8-bit shift register Florian Fainelli
2010-08-30 23:43 ` David Brownell
2010-08-31 8:17 ` Florian Fainelli [this message]
2010-08-31 10:44 ` [PATCH v3] GPIO: add support for 74x164 " Florian Fainelli
2010-09-01 7:25 ` Florian Fainelli
2010-09-01 9:37 ` [PATCH v4] " Florian Fainelli
2010-09-07 0:41 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008311017.30445.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=juhosg@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.gaio@efixo.com \
--cc=sameo@linux.intel.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox