Re: [PATCH 1/3] [lockup detector] sync touch_*_watchdog back to old semantics

Cyrill Gorcunov
2010-09-01T16:36:39Z

On Wed, Sep 01, 2010 at 11:51:12AM -0400, Don Zickus wrote:
> Top posting because droid won't let me bottom post
>
> This patch was the result of a regression with acpi and preempt.
> Akpm asked that I not change the semantics of the old touch_nmi_watchdog.
> So I tried to revert to the old behaviour.
>
> Sorry for not properly explaining that.
>

yup, stareing at old behaviour I think there is a place where we could
get rid of traversing all cpus: native_cpu_up() -- I don't get the reason why
watchdog counter should be reset on every other cpu as well. Perhaps
I miss something. On the other hands I think changing behaviour of
touch_nmi_watchdog just for one entry might not be worth thing to do :)

> Cheers,
> Don
>
> Ingo Molnar <mingo@elte.hu> wrote:
>
...
> >Ok - can you cite the old watchdog code, did it really do a nr_cpus
> >loop?
> >
> >Thanks,
> >
> > Ingo

-- Cyrill