From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755348Ab0IANuu (ORCPT ); Wed, 1 Sep 2010 09:50:50 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:34146 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754990Ab0IANuq (ORCPT ); Wed, 1 Sep 2010 09:50:46 -0400 Date: Wed, 1 Sep 2010 15:50:42 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Trond Myklebust Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, "J. Bruce Fields" , Randy Dunlap , Neil Brown , Linus Torvalds Subject: Re: [REGRESSION PATCH v2] NFS: let NFS_V4 and NFSD_V4 enforce CRYPTO Message-ID: <20100901135041.GC11107@pengutronix.de> References: <20100830121022.GA14459@pengutronix.de> <1283331170-11440-1-git-send-email-u.kleine-koenig@pengutronix.de> <1283347024.3184.8.camel@heimdal.trondhjem.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1283347024.3184.8.camel@heimdal.trondhjem.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 01, 2010 at 09:17:04AM -0400, Trond Myklebust wrote: > On Wed, 2010-09-01 at 10:52 +0200, Uwe Kleine-König wrote: > > Hello, > > > > here comes a v2 of the patch that improves the commit log with a more > > detailed analysis of the breakage introduced by df486a2 > > (= v2.6.36-rc2~34^2~1 BTW) and additionally undoes the "default y" for > > RPCSEC_GSS_KRB5. > > > > So compared to the state before df486a2 the changes are: > > > > NFS_V4 selects CRYPTO > > NFSD_V4 selects CRYPTO > > RPCSEC_GSS_KRB5 doesn't depend on EXPERIMENTAL anymore > > RPCSEC_GSS_KRB5 now depends on CRYPTO instead of selecting it > > > > Best regards > > Uwe > > > > ----------------------------->8---------------------------- > > > > This is a follow up to > > > > df486a2 (NFS: Fix the selection of security flavours in Kconfig) > > > > Before df486a2 NFS_V4 selected RPCSEC_GSS_KRB5 but didn't enforce the > > latter's dependency EXPERIMENTAL. df486a2 removed RPCSEC_GSS_KRB5's > > dependency on EXPERIMENTAL but additionally let it depend on CRYPTO > > (instead of select CRYPTO before). So it was still possible to have a > > config that has NFS_V4 but not RPCSEC_GSS_KRB5. Moreover df486a2 > > changed the dependency of NFS_V4 and NFSD_V4 on RPCSEC_GSS_KRB5 from > > As I said, the fix is to remove that dependency. I have a fix for the > NFS client, but the server has more insidious dependencies on RPCSEC_GSS > due to a poorly designed SECINFO implementation. Yes, I still remember this, so I suggest to take my patch before 2.6.36 and you can fix it in the merge window for 2.6.37, no? Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |