From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Avi Kivity <avi@redhat.com>, Li Zefan <lizf@cn.fujitsu.com>,
kvm-devel <kvm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: ftrace/perf_event leak
Date: Wed, 1 Sep 2010 19:32:53 +0200 [thread overview]
Message-ID: <20100901173253.GC23357@elte.hu> (raw)
In-Reply-To: <1283349585.2356.1.camel@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 2010-09-01 at 14:15 +0200, Frederic Weisbecker wrote:
>
> > Thanks for fixing this.
> >
> > However, can we split this in two patches to ease the backport?
> >
> > The lack of a module_put() after perf_trace_init() failure is there for a while
> > (the backport needs to start in 2.6.32).
> >
> > But the lack of a module_put in the destroy path needs a .35 backport only.
>
> I don't think it really needs two patches. Just notify stable (and
> Greg KH in particular) about the backport requirements. Greg can
> handle it ;)
Well, Greg certainly has more than enough to handle, so if there's
different chunks with different -stable vectors then it would be most
helpful to him to split things up!
Manually trying to split up patches is both error-prone and
stress-inducing.
Thanks,
Ingo
next prev parent reply other threads:[~2010-09-01 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 8:42 ftrace/perf_event leak Avi Kivity
2010-09-01 9:04 ` Peter Zijlstra
2010-09-01 9:26 ` Avi Kivity
2010-09-01 9:35 ` Peter Zijlstra
2010-09-01 9:38 ` Li Zefan
2010-09-01 9:41 ` Peter Zijlstra
2010-09-01 10:38 ` Avi Kivity
2010-09-01 11:02 ` Peter Zijlstra
2010-09-01 11:07 ` Ingo Molnar
2010-09-01 12:15 ` Frederic Weisbecker
2010-09-01 13:59 ` Steven Rostedt
2010-09-01 17:32 ` Ingo Molnar [this message]
2010-09-02 1:20 ` Li Zefan
2010-09-09 19:45 ` [tip:perf/core] perf, trace: Fix module leak tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100901173253.GC23357@elte.hu \
--to=mingo@elte.hu \
--cc=avi@redhat.com \
--cc=fweisbec@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox