Re: [RFC] [PATCH] cfq-iosched: add cfq group hierarchical scheduling support

[Vivek Goyal <vgoyal@redhat.com>]

On Wed, Sep 01, 2010 at 04:50:22PM +0800, Gui Jianfeng wrote:

[..]

> Hi Vivek，
> 
> Even if we mount cpu and blkio together, to me, it's ok for cpu and blkio
> having their own logic, since they are totally different cgroup subsystems.
> 
> > 
> > - To me, both group and cfq queue are children of root group and it
> >   makes sense to treat them independent childrens instead of putting
> >   all the queues in one logical group which inherits the weight of
> >   parent.
> > 
> > - With this new scheme, I am finding it hard to visualize the hierachy.
> >   How do you assign the weights to queue entities of a group. It is more
> >   like a invisible group with-in group. We shall have to create new
> >   tunable which can speicy the weight for this hidden group.
> 
> For the time being, the root "qse" weight is 1000 and others is 500, they don't
> inherit the weight of parent. I was thinking that maybe we can determine the qse
> weight in term of the queue number and weight in this group and subgroups. 

If you decide queue weight in terms of queue number, then you are back to
the same problem Nauman was mentioning that share of a group is not fixed
and depends on number of queues in the group.

Vivek