From: Anton Vorontsov <cbouatmailru@gmail.com>
To: rklein@nvidia.com
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
olof@lixom.net, achew@nvidia.com, khali@linux-fr.org,
broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC
Date: Thu, 2 Sep 2010 21:47:36 +0400 [thread overview]
Message-ID: <20100902174736.GA28649@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1283448586-14613-1-git-send-email-rklein@nvidia.com>
On Thu, Sep 02, 2010 at 10:29:46AM -0700, rklein@nvidia.com wrote:
> From: Rhyland Klein <rklein@nvidia.com>
>
> this driver depends on I2C and uses SMBUS for communication with the host.
>
> Addressed comments from reviews by Mark Brown and Jean Delvare.
> * Cleaned up whitespace and alignment issues
> * changed return codes to more appropriate values
> * change Kconfig option name to be consistent with existing devices
> * removed global struct and moved to device specific data
> * changed printk to dev_dbg
The driver looks good to me. But I'll wait a day or two for Jean's
and Mark's Acked-by or Reviewed-by tags before applying, just to
give them some credit for reviwing this driver.
Thanks!
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-09-02 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 17:29 [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC rklein
2010-09-02 17:47 ` Anton Vorontsov [this message]
2010-09-04 21:00 ` Rhyland Klein
2010-09-05 8:47 ` Mark Brown
2010-09-05 8:49 ` Rhyland Klein
2010-09-05 8:59 ` Mark Brown
2010-09-03 9:43 ` Mark Brown
2010-09-05 14:15 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902174736.GA28649@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=achew@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox