From: Ingo Molnar <mingo@elte.hu>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: mingo@redhat.com, hpa@zytor.com, julia@diku.dk,
linux-kernel@vger.kernel.org, penberg@cs.helsinki.fi,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/mm] x86, kmemcheck: Remove double test
Date: Fri, 3 Sep 2010 08:21:50 +0200 [thread overview]
Message-ID: <20100903062150.GC19074@elte.hu> (raw)
In-Reply-To: <AANLkTi=-7Dq09Svwo9nwYA4xzZx4NJapPigW6SodF6g4@mail.gmail.com>
* Vegard Nossum <vegard.nossum@gmail.com> wrote:
> On 30 August 2010 10:36, tip-bot for Julia Lawall <julia@diku.dk> wrote:
> > Commit-ID: 9fbaf49c7f717740002d49eee1bbd03d89d8766a
> > Gitweb: http://git.kernel.org/tip/9fbaf49c7f717740002d49eee1bbd03d89d8766a
> > Author: Julia Lawall <julia@diku.dk>
> > AuthorDate: Sat, 28 Aug 2010 17:41:03 +0200
> > Committer: Ingo Molnar <mingo@elte.hu>
> > CommitDate: Mon, 30 Aug 2010 09:19:28 +0200
> >
> > x86, kmemcheck: Remove double test
> >
> > The opcodes 0x2e and 0x3e are tested for in the first Group 2
> > line as well.
> >
> > The sematic match that finds this problem is as follows:
> > (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @expression@
> > expression E;
> > @@
> >
> > (
> > * E
> > || ... || E
> > |
> > * E
> > && ... && E
> > )
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@diku.dk>
> > Reviewed-by: Pekka Enberg <penberg@cs.helsinki.fi>
> > Cc: Vegard Nossum <vegardno@ifi.uio.no>
> > LKML-Reference: <1283010066-20935-5-git-send-email-julia@diku.dk>
> > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > ---
> > arch/x86/mm/kmemcheck/opcode.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
>
> Sorry, was a bit late.
>
> Thanks for the patch, review, and picking up :-)
You are welcome :)
Ingo
next prev parent reply other threads:[~2010-09-03 6:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 15:40 [PATCH 0/7] Remove double test Julia Lawall
2010-08-28 15:41 ` [PATCH 1/7] drivers/staging: " Julia Lawall
2010-08-28 15:41 ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 16:10 ` David Brownell
2010-08-28 16:53 ` Julia Lawall
2010-08-28 17:11 ` Stefan Richter
2010-08-28 17:17 ` Julia Lawall
2010-08-28 18:11 ` David Brownell
2010-08-28 18:19 ` David Brownell
2010-08-28 16:37 ` Dan Carpenter
2010-08-28 16:48 ` [PATCH 2/7] drivers/usb/gadget/amd5536udc.c: " Julia Lawall
2010-08-28 18:24 ` David Brownell
2010-09-01 10:03 ` Thomas Dahlmann
2010-08-28 16:49 ` [PATCH 2/7] drivers/usb/gadget: " Julia Lawall
2010-08-28 15:41 ` [PATCH 3/7] drivers/net/atl1c: " Julia Lawall
2010-08-28 16:50 ` Dan Carpenter
2010-08-28 20:10 ` Luis R. Rodriguez
2010-08-28 15:41 ` [PATCH 4/7] arch/x86/mm/kmemcheck: " Julia Lawall
2010-08-29 10:26 ` Pekka Enberg
2010-08-30 8:36 ` [tip:x86/mm] x86, kmemcheck: " tip-bot for Julia Lawall
2010-09-02 19:08 ` Vegard Nossum
2010-09-03 6:21 ` Ingo Molnar [this message]
2010-08-28 15:41 ` [PATCH 5/7] drivers/regulator: " Julia Lawall
2010-08-29 13:06 ` Mark Brown
2010-08-28 15:41 ` [PATCH 6/7] drivers/media/dvb/siano: " Julia Lawall
2010-08-28 15:41 ` [PATCH 7/7] net/wireless: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100903062150.GC19074@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox